224: decoding payments locally for offchain accounting

[murraystewart96]

#224

Pull Request Checklist

• Update MinLndVersion if your PR uses new RPC methods or fields of lnd.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a local decoding mechanism for payment requests within the accounting module. By leveraging the zpay32 library directly, the application can now decode payment requests without needing to perform an external RPC call to lnd, which streamlines the offchain accounting process.

Highlights

• Local Payment Decoding: Implemented local decoding of payment requests using zpay32 instead of relying on an RPC call to lnd.
• Configuration Update: Updated NewOffChainConfig to utilize the new local decoding function, improving efficiency for offchain accounting.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request replaces the RPC-based payment request decoding with a local implementation using the zpay32 library in accounting/config.go. Feedback indicates that the new decodePaymentReq function only populates the Destination and Description fields, which is a regression from the previous implementation. It is recommended to populate additional fields such as Amount and PaymentHash to maintain parity and ensure robustness for future use cases.