fix(rpcserver): normalized REST bytes base64 handling for path and query#2134
fix(rpcserver): normalized REST bytes base64 handling for path and query#2134sergey3bv wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the robustness of the REST API by standardizing how byte-based fields are parsed. By normalizing various base64 encoding formats, the API becomes more flexible for different client implementations. Additionally, it enforces stricter validation by returning explicit error responses for malformed input, preventing ambiguous or silent failures. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
6667bc0 to
c1d6238
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces REST bytes normalization to support various base64 variants (standard, URL-safe, padded, and unpadded) for specific fields in both path and query parameters. It includes a new middleware and query parameter parser, along with comprehensive integration and unit tests. Feedback focuses on expanding the set of normalized fields, improving the reliability of path extraction, optimizing performance by reducing allocations, and ensuring all new functions adhere to the repository's documentation style guide.
c1d6238 to
ffba4d6
Compare
Should close #2075