Aligning ListAssets/FetchAsset group_key behavior with ListBalances

[sergey3bv]

Should close #2076

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aligns the filtering behavior of ListAssets and FetchAsset with ListBalances when querying by group key. Previously, these RPCs defaulted to filtering by BIP-0086 script keys, which could lead to discrepancies when viewing grouped assets. The changes ensure that when a group key is provided without an explicit script key type, all associated assets are returned, providing a more intuitive and consistent user experience.

Highlights

• RPC Behavior Alignment: Updated ListAssets and FetchAsset to include all script key types by default when querying by group key, ensuring consistency with ListBalances.
• Documentation and API Updates: Updated taprpc proto definitions to reflect the new default behavior for group key queries and added a release note entry.
• Testing: Added integration tests in itest/burn_test.go to verify that group key queries without explicit script key types return all relevant assets.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aligns the behavior of ListAssets and FetchAsset with ListBalances by defaulting to all script key types when a group key filter is provided without an explicit script key type. The changes include updates to the RPC server logic, Protobuf documentation, and integration tests to verify the new behavior. Feedback was provided regarding a potential inconsistency: while the PR aims for alignment, ListBalances itself may still default to SCRIPT_KEY_BIP86 via its internal parsing logic, suggesting that ListBalances should also be explicitly updated to ensure consistent behavior across all related RPCs.