Fixing ListBatches REST path filter silently returns empty on wrong batch_key encoding by sergey3bv · Pull Request #2137 · lightninglabs/taproot-assets

sergey3bv · 2026-05-15T11:18:23Z

Should close #2080

gemini-code-assist · 2026-05-15T11:18:32Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the ListBatches REST endpoint would silently return empty results when provided with incorrectly encoded batch keys. By migrating the path parameter to a string-based representation and introducing strict validation logic, the API now provides clear feedback when invalid inputs are received, improving robustness and developer experience.

Highlights

REST API Path Update: Updated the ListBatches REST endpoint to use batch_key_str instead of batch_key in the path to ensure proper handling of batch key encoding.
Error Handling: Implemented explicit validation for batch_key and batch_key_str filters, ensuring that malformed or empty keys now return an InvalidArgument error instead of silently returning empty results.
Testing: Added a new integration test to verify that the REST endpoint correctly rejects malformed batch keys with appropriate status codes.

New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the ListBatches REST endpoint to use batch_key_str in the path and ensures that malformed or empty batch keys return an InvalidArgument error. It also adds an integration test to verify correct handling of various batch key encodings. Feedback focuses on adhering to the repository style guide, specifically regarding the placement of comments within switch statements and the minimization of lines for error message formatting in rpcserver.go.

darioAnongba · 2026-05-15T15:27:43Z

 	// parallel tranches, tapd block processing can be slow so we use a
 	// generous timeout.
-	ccTransferTimeout = 2 * time.Minute
+	ccTransferTimeout = 3 * time.Minute


Please remove from PR.

darioAnongba · 2026-05-15T15:27:54Z

+	ctxt, cancel := context.WithTimeout(
+		ctxb, defaultWaitTimeout*4,
+	)


Please remove from PR.

darioAnongba · 2026-05-15T15:32:45Z

+				"invalid batch_key: %v", err)
 		}
+
+	default:


either no default here or a generic unsupported filter type with a // should be unreachable comment.

darioAnongba · 2026-05-15T15:33:44Z

+				batchKey,
+			),
+			statusCode: []int{
+				http.StatusBadRequest, http.StatusNotFound,


why accept multiple status codes here?

darioAnongba · 2026-05-15T15:35:55Z

+	}
+
+	for _, testCase := range testCases {
+		testCase := testCase


not needed in modern Go 1.22+

darioAnongba · 2026-05-15T15:38:20Z

-			return nil, fmt.Errorf("invalid batch key string: %w",
-				err)
+			return nil, status.Errorf(codes.InvalidArgument,
+				"invalid batch_key: %v", err)


old error messages seemed alright. Here you are pretending to now what the field name is (happens to also be wrong since it's batch_key_str).

darioAnongba · 2026-05-15T15:38:23Z

 		if err != nil {
-			return nil, fmt.Errorf("invalid batch key: %w", err)
+			return nil, status.Errorf(codes.InvalidArgument,
+				"invalid batch_key: %v", err)


old error messages seemed alright. Here you are pretending to now what the field name is (happens to also be wrong since it's batch_key_str).

darioAnongba · 2026-05-15T15:38:31Z

 		if err != nil {
-			return nil, fmt.Errorf("invalid batch key: %w", err)
+			return nil, status.Errorf(codes.InvalidArgument,
+				"invalid batch_key: %v", err)


old error messages seemed alright. Here you are pretending to now what the field name is.

github-project-automation Bot added this to Taproot-Assets Project Board May 15, 2026

github-project-automation Bot moved this to 🆕 New in Taproot-Assets Project Board May 15, 2026

sergey3bv force-pushed the fix/rest-empty-return branch from 46aaa41 to 4ad88ea Compare May 15, 2026 11:19

gemini-code-assist Bot reviewed May 15, 2026

View reviewed changes

sergey3bv added 2 commits May 15, 2026 15:47

fix: ListBatches REST batch_key handling

3ab48ae

docs: updating release notes

81c1f7d

sergey3bv force-pushed the fix/rest-empty-return branch from 4ad88ea to 81c1f7d Compare May 15, 2026 12:47

sergey3bv marked this pull request as ready for review May 15, 2026 13:04

sergey3bv mentioned this pull request May 15, 2026

ListBatches REST path filter silently returns empty on wrong batch_key encoding #2080

Open

darioAnongba self-requested a review May 15, 2026 15:09

darioAnongba requested changes May 15, 2026

View reviewed changes

github-project-automation Bot moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board May 15, 2026

Conversation

sergey3bv commented May 15, 2026

Uh oh!

gemini-code-assist Bot commented May 15, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants