webapi: XHR uses XML parser for XML content-type responses#3036
Merged
Conversation
Expand mime type to be aware of more XML types. DOMParser and XHR now use the existing Parser.parseXML (via a Frame helper), rather than the HTML parser. Both these APIs predate the addition of parseXML.
Follows the observer, user_input, etc.. pattern and relocates various `Frame.parse*` methods into Frame.parse.* functions. Goal is just to keep Frame neat.
karlseguin
force-pushed
the
xhr-xmlresponse
branch
from
July 25, 2026 02:30
b60fe5f to
705bc78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand mime type to be aware of more XML types. DOMParser and XHR now use the existing Parser.parseXML (via a Frame helper), rather than the HTML parser. Both these APIs predate the addition of parseXML.
The 2nd commit is a mechanical change where various Frame.parse* methods have been moved to a Frame.parse.* utility class (like observers and user_input). The goal is just to keep the complex Frame neater.