Skip to content

Conversation

@pengying
Copy link
Contributor

@pengying pengying commented Jan 24, 2026

Grid API SDK Configuration

  • Add .stainless/stainless.yml and workspace.json for SDK generation
  • Add AllErrors schema to properly handle error types
  • Replace Error schema references with GridError
  • Fix phone number format in UltimateBeneficialOwner to include '+' prefix
  • Update .redocly.lint-ignore.yaml with additional rule exceptions
  • Fix internal_accounts schema reference path

@greptile-apps
Copy link

greptile-apps bot commented Jan 24, 2026

Greptile Overview

Greptile Summary

Adds Stainless SDK configuration to enable TypeScript and Kotlin SDK generation from the OpenAPI specification, along with several OpenAPI schema improvements.

Key Changes:

  • Added .stainless/stainless.yml with comprehensive SDK generation configuration including resource mappings, authentication settings, pagination, and error handling
  • Created .stainless/workspace.json to define project structure and output paths
  • Added AllErrors union schema that consolidates all error types (Error400-Error501) for proper SDK error handling
  • Renamed Error schema to GridError to avoid naming conflicts
  • Fixed UltimateBeneficialOwner phone number example to include '+' prefix, matching the E.164 format pattern
  • Corrected schema reference path from users/InternalAccount.yaml to customers/InternalAccount.yaml
  • Updated .redocly.lint-ignore.yaml with exceptions for the new AllErrors schema and existing Quote schema validation issues

All changes are properly reflected in both the modular OpenAPI files and the bundled openapi.yaml and mintlify/openapi.yaml files.

Confidence Score: 5/5

  • This PR is safe to merge with no issues found
  • All changes are well-structured configuration and schema improvements. The Stainless SDK config is comprehensive and follows best practices, schema references have been verified to exist, the phone number format fix correctly matches the pattern, and all bundled files are properly synchronized with source files.
  • No files require special attention

Important Files Changed

Filename Overview
.stainless/stainless.yml Added comprehensive Stainless SDK configuration for TypeScript and Kotlin SDK generation with proper resource mappings and authentication settings
.stainless/workspace.json Created Stainless workspace config pointing to OpenAPI spec and TypeScript SDK output directory
openapi/openapi.yaml Added AllErrors union schema to consolidate all error types for SDK generation
openapi/components/schemas/customers/UltimateBeneficialOwner.yaml Fixed phone number example to include '+' prefix matching E.164 format pattern
openapi/paths/internal-accounts/internal_accounts.yaml Fixed schema reference path from users/InternalAccount.yaml to customers/InternalAccount.yaml

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Stainless as Stainless SDK Generator
    participant OpenAPI as OpenAPI Spec
    participant SDK as Generated SDK
    
    Dev->>OpenAPI: Add AllErrors union schema
    Dev->>OpenAPI: Rename Error to GridError
    Dev->>OpenAPI: Fix phone number format
    Dev->>OpenAPI: Fix schema reference paths
    
    Dev->>Stainless: Create stainless.yml config
    Note over Stainless: Define resources, models, methods<br/>Configure authentication<br/>Set error handling
    
    Dev->>Stainless: Create workspace.json
    Note over Stainless: Point to OpenAPI spec<br/>Define output paths
    
    Stainless->>OpenAPI: Read OpenAPI spec
    Stainless->>Stainless: Transform AllErrors using splitSchemasByEnumProperty
    Stainless->>SDK: Generate TypeScript SDK
    Stainless->>SDK: Generate Kotlin SDK
    
    Note over SDK: SDKs now have proper error types,<br/>correct schema references,<br/>and valid examples
Loading

@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split branch from 6432728 to e5749d2 Compare January 27, 2026 01:29
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split_split branch from 21d334e to f90918a Compare January 27, 2026 01:29
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split branch from e5749d2 to a27f6e6 Compare January 27, 2026 05:19
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split_split branch from f90918a to c6b215b Compare January 27, 2026 05:19
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split branch from a27f6e6 to a1379cd Compare January 27, 2026 05:24
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split_split branch from c6b215b to 6464d8a Compare January 27, 2026 05:25
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split branch from a1379cd to d0f0475 Compare January 27, 2026 20:38
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split_split branch 2 times, most recently from 2d0527c to 16c31c5 Compare January 27, 2026 21:19
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split branch 2 times, most recently from 94a379a to c72b46f Compare January 27, 2026 23:54
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split_split branch from 16c31c5 to 20ea4a3 Compare January 27, 2026 23:54
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split branch from c72b46f to 99a29c9 Compare January 27, 2026 23:57
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split_split branch from 20ea4a3 to d1566ae Compare January 27, 2026 23:57
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split branch from 99a29c9 to d8d7c4d Compare January 28, 2026 00:08
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split_split branch 2 times, most recently from 7324f44 to 3aa1250 Compare January 28, 2026 00:15
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split branch from 1c31c37 to fbf418e Compare January 28, 2026 00:27
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split_split branch from 3aa1250 to f054ac0 Compare January 28, 2026 00:27
- Add .stainless/stainless.yml and workspace.json
- Add AllErrors schema and remove retry quotes endpoint
- Update .redocly.lint-ignore.yaml
- Fix UltimateBeneficialOwner phone format
- Fix internal_accounts ref path
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split branch from fbf418e to 48e70c8 Compare January 28, 2026 04:32
@pengying pengying force-pushed the 01-24-feat_flatten_lightningexternalaccountinfo_schema_split_split_split_split_split branch from f054ac0 to 2ac3b42 Compare January 28, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants