luzer/tests: fix a test for LuaJIT friendly mode#81
Open
Conversation
The test luzer_luajit_friendly_test fails due to the hardcoded LUA_PATH if one builds luzer with non-system LuaJIT because LuaJIT internal module is used by the test. The patch fixes that by using environment variable LUA_PATH. The environment variable LUA_PATH should be set before running CMake configuration. Fixes #80
Buristan
approved these changes
Apr 3, 2026
Collaborator
Buristan
left a comment
Buristan
left a comment
There was a problem hiding this comment.
LGTM, with a minor nits regarding the commit message.
LUA_PATH if one builds luzer with non-system LuaJIT because LuaJIT
Typo: s/non-system LuaJIT/a non-system LuaJIT/
Typo: s/because LuaJIT/because LuaJIT's/
internal module is used by the test. The patch fixes that by using
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test luzer_luajit_friendly_test fails due to the hardcoded LUA_PATH if one builds luzer with non-system LuaJIT because LuaJIT internal module is used by the test. The patch fixes that by using environment variable LUA_PATH. The environment variable LUA_PATH should be set before running CMake configuration.
Fixes #80