Skip to content
This repository was archived by the owner on Dec 18, 2019. It is now read-only.

add bik bitv link rendering#123

Open
JonasHillerDkd wants to merge 5 commits into
liip:masterfrom
dkd:feature/OLD_92425-add_bik_bitv_link_rendering
Open

add bik bitv link rendering#123
JonasHillerDkd wants to merge 5 commits into
liip:masterfrom
dkd:feature/OLD_92425-add_bik_bitv_link_rendering

Conversation

@JonasHillerDkd

Copy link
Copy Markdown

This feature renders a link to the BITV 2.0 testing step, the german accessibility standard, to each, similar WCAG 2.0 Note Code.

Comment thread view/reports/report.html
)
.join(', ')
%> <code>#<%- result.code %></code></p>
<p>BIK BITV Prüfschritt:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part should go in the p.notes element.

Comment thread view/reports/report.html
if (bikCodeMapItem.noteCode === noteCode) {
_.map(
bikCodeMapItem.bikTestSteps,
function (bikTestStepsItem) { %>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to be consistent with the rest of the file, please return a string instead of closing the <% … %>, thanks.

@JonasHillerDkd JonasHillerDkd Oct 1, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it with the Return statement, but it returns nothing

do you know why?

BIK BITV Prüfschritt:
<% _.map(
    result.noteCodes,
    function (noteCode) {
        _.map(
            bikCodeMap,
            function (bikCodeMapItem) {
                if (bikCodeMapItem.noteCode === noteCode) {
                    _.map(
                        bikCodeMapItem.bikTestSteps,
                        function (bikTestStepsItem) {
                            return '<a href="' + bikTestStepsItem.url + '"> + bikTestStepsItem.name  + '</a>';
                            }
                    )
                }
            }
        )
    }
)%>

Comment thread view/reports/report.html
<% }
)
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the empty line.

@@ -0,0 +1,2681 @@
{

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where this file comes from?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i created it manually. I investigated the diffrence beetwen the BITV Standard and the WCAG techniques. The result was the the BITV test steps and the WCAG techniques was similar if not even the same.

Comment thread package.json Outdated
"dependencies": {
"HTML_CodeSniffer": "https://github.com/squizlabs/HTML_CodeSniffer#master",
"async": "^2.1.4",
"HTML_CodeSniffer": "git+https://github.com/squizlabs/HTML_CodeSniffer.git#d209ce54876657858a8a01528ad812cd234f37f0", "async": "^2.1.4",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is from #121, please consider removing it.

@Hywan

Hywan commented Sep 14, 2018

Copy link
Copy Markdown
Contributor

Thanks for the PR! I would be in favor of adding BITV codes if only I knew them :-). Is it something from an official law?

@Hywan

Hywan commented Sep 14, 2018

Copy link
Copy Markdown
Contributor

Please @goldi42, can you use English to talk here :-)? If you don't know English, feel free to use a translator.


Bitte @goldi42, kannst du Englisch benutzen, um hier zu reden :-)? Wenn Sie kein Englisch sprechen, können Sie gerne einen Übersetzer benutzen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants