Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Console.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
use Codeception\Subscriber\Console as SubscriberConsole;

class Console extends SubscriberConsole {
public function printFail(FailEvent $event, ?int $eventNumber = null): void {
public function printFail(FailEvent $event, ?string $eventNumber = null): void {
$method = new \ReflectionMethod(SubscriberConsole::class, 'printFail');

$args = [$event];
Expand Down
8 changes: 4 additions & 4 deletions src/GitHubReporter.php
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ public function after(TestEvent $e) {
$this->standardReporter->endTest($e);
}

public function printFailed(FailEvent $e, int $eventNumber): void {
public function printFailed(FailEvent $e, ?string $eventNumber=null): void {
$failedTest = $e->getTest();
$fail = $e->getFail();

Expand Down Expand Up @@ -160,23 +160,23 @@ private function getReports(TestInterface $failedTest) {
}
}

private function getTestSignature(TestInterface $test): string {
private function getTestSignature($test): string {
if ($test instanceof Descriptive) {
return Descriptor::getTestSignature($test);
}

return method_exists($test, 'toString') ? $test->toString() : get_class($test);
}

private function getTestAsString(TestInterface $test): string {
private function getTestAsString($test): string {
if ($test instanceof Descriptive) {
return Descriptor::getTestAsString($test);
}

return method_exists($test, 'toString') ? $test->toString() : get_class($test);
}

private function getTestFullName(TestInterface $test): string {
private function getTestFullName($test): string {
if ($test instanceof Descriptive || $test instanceof Plain) {
return Descriptor::getTestFullName($test);
}
Expand Down
2 changes: 1 addition & 1 deletion src/StackTrace.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public function getExceptionTrace($e) {
return;
}

$trace = \PHPUnit\Util\Filter::getFilteredStacktrace($e);
$trace = explode("\n", \PHPUnit\Util\Filter::getFilteredStacktrace($e));

$i = 0;
foreach ($trace as $step) {
Expand Down
Loading