Skip to content

Support async translation publishing#149

Open
hadomskyi wants to merge 3 commits into3.xfrom
3.x-async-publishing
Open

Support async translation publishing#149
hadomskyi wants to merge 3 commits into3.xfrom
3.x-async-publishing

Conversation

@hadomskyi
Copy link
Copy Markdown
Collaborator

ENG-12759

@hadomskyi hadomskyi force-pushed the 3.x-async-publishing branch 6 times, most recently from a3a33ed to 3e35164 Compare April 21, 2024 17:07
@hadomskyi hadomskyi force-pushed the 3.x-async-publishing branch from 3e35164 to 9e6c8e4 Compare April 21, 2024 17:09
Copy link
Copy Markdown
Collaborator

@tgallant tgallant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the tests!

# Conflicts:
#	.github/workflows/craft-versions.yml
#	.github/workflows/e2e.yml
#	e2e/cypress/support/flow/instant.js
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 69.74522% with 95 lines in your changes missing coverage. Please review.

Project coverage is 70.00%. Comparing base (f12c4a4) to head (52db214).

Files with missing lines Patch % Lines
src/modules/PublishTranslation.php 12.50% 56 Missing ⚠️
src/services/handlers/PublishDraftHandler.php 79.41% 21 Missing ⚠️
src/services/repositories/JobRepository.php 0.00% 6 Missing ⚠️
...dules/FetchInstantJobTranslationsFromConnector.php 0.00% 5 Missing ⚠️
...ules/FetchVerifiedJobTranslationsFromConnector.php 0.00% 5 Missing ⚠️
src/services/handlers/RefreshJobStatusHandler.php 95.45% 1 Missing ⚠️
src/services/repositories/SettingsRepository.php 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.x     #149      +/-   ##
============================================
- Coverage     70.44%   70.00%   -0.44%     
- Complexity      940      976      +36     
============================================
  Files           117      120       +3     
  Lines          4788     4998     +210     
============================================
+ Hits           3373     3499     +126     
- Misses         1415     1499      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants