Conversation
1 similar comment
| o *C.PyObject | ||
| } | ||
|
|
||
| var baseObjMap = make(map[*C.PyObject]*BaseObject) |
There was a problem hiding this comment.
I don't get why are you removing this? and similar ones.
There was a problem hiding this comment.
it causes memory leaks. there is no code which in charge to remove an item from the map
There was a problem hiding this comment.
But doesn't this enable us to reuse an object created before and not create it again?
There was a problem hiding this comment.
I think its broken by design, i mean the way to save few bytes and couple milliseconds :) and caused a lot of memory leaks with random data. There are two ways to fix it:
- remove the reason (pull request)
- implement some kind of TTL (time to live) for every single item stored this way
its your repo, your choice :)
Anyway, i've forked this repo and using it without leaks
There was a problem hiding this comment.
Ok, so I will check if there is any problem with other repositories while using these changes. Thanks
|
I have checked this. Although the tests are passing but with https://github.com/limetext/sublime, It's causing panic: |
|
Reopenning this because the error mentioned is not related to this pr. We should test this after resolving #16. |
1 similar comment
|
This should get applied after resolving #12 (comment). |
No description provided.