This repository was archived by the owner on Dec 3, 2025. It is now read-only.
feat: use dynamic import and make api async#16
Open
betocantu93 wants to merge 9 commits intolinc-technologies:mainfrom
Open
feat: use dynamic import and make api async#16betocantu93 wants to merge 9 commits intolinc-technologies:mainfrom
betocantu93 wants to merge 9 commits intolinc-technologies:mainfrom
Conversation
yes, it seems youre right seems a bug Co-authored-by: Matthew Hartstonge <matt@mykro.co.nz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, nice wrapper, been using it for a while... this PR just makes the excel service api async in order to support dynamic imports, it also removes the Blob polyfill and move deps to peerDependencies, let host app decide the version it wants from XLSX and file-saver.