test: add TypeScript type-checking for tests

.github/workflows/ci-validate.yml

@@ -77,6 +77,9 @@ jobs:
       - name: TypeScript type check
         run: npx tsc --noEmit
 
+      - name: Test TypeScript type check
+        run: npm run test:typecheck
+
   commitlint:
     name: Validate Commit Messages
     runs-on: ubuntu-latest

package.json

@@ -19,6 +19,7 @@
     "clean": "rm -rf dist/",
     "start": "tsx src/main.ts",
     "test": "vitest run",
+    "test:typecheck": "tsc -p tsconfig.test.json --noEmit",
     "test:integration": "vitest run --config vitest.integration.config.ts",
     "test:watch": "vitest",
     "test:ui": "vitest --ui",

scripts/release/calver-plugin.d.cts

@@ -0,0 +1,27 @@
+export interface MapCalverReleaseTypeInput {
+  branchName: string;
+  releaseType: string | null;
+  lastVersion: string;
+  nowIso?: string;
+}
+
+export interface AnalyzeCommitsContext {
+  branch?: { name?: string };
+  lastRelease?: { version?: string };
+  logger: { log(message: string): void };
+  nextRelease?: { version?: string };
+}
+
+export declare function mapCalverReleaseType(
+  input: MapCalverReleaseTypeInput,
+): string | null;
+
+export declare function analyzeCommits(
+  pluginConfig: unknown,
+  context: AnalyzeCommitsContext,
+): Promise<string | null>;
+
+export declare function verifyRelease(
+  pluginConfig: unknown,
+  context: AnalyzeCommitsContext,
+): Promise<void>;

scripts/release/calver.d.cts

@@ -0,0 +1,13 @@
+export interface ComputeCalverVersionInput {
+  lastVersion: string;
+  branchName: string;
+  nowIso?: string;
+}
+
+export declare function computeCalverVersion(
+  input: ComputeCalverVersionInput,
+): string;
+
+export declare function isMonthRollover(
+  input: ComputeCalverVersionInput,
+): boolean;

tests/unit/services/initiative-service.test.ts

@@ -1,7 +1,10 @@
 import { type DocumentNode, type FragmentDefinitionNode, Kind } from "graphql";
 import { describe, expect, it, vi } from "vitest";
 import type { GraphQLClient } from "../../../src/client/graphql-client.js";
-import { GetInitiativeDocument } from "../../../src/gql/graphql.js";
+import {
+  GetInitiativeDocument,
+  PaginationOrderBy,
+} from "../../../src/gql/graphql.js";
 import {
   archiveInitiative,
   createInitiative,
@@ -72,15 +75,15 @@ describe("listInitiatives", () => {
       after: "cursor-1",
       includeArchived: true,
       filter: { name: { eqIgnoreCase: "Growth" } },
-      orderBy: { createdAt: "Asc" },
+      orderBy: PaginationOrderBy.CreatedAt,
     });
 
     expect(client.request).toHaveBeenCalledWith(expect.anything(), {
       first: 10,
       after: "cursor-1",
       includeArchived: true,
       filter: { name: { eqIgnoreCase: "Growth" } },
-      orderBy: { createdAt: "Asc" },
+      orderBy: PaginationOrderBy.CreatedAt,
       sort: undefined,
     });
   });

tests/unit/services/issue-service.test.ts

@@ -368,7 +368,8 @@ describe("getIssueByIdentifierWithComments", () => {
     });
     const result = await getIssueByIdentifierWithComments(client, "ENG", 42);
 
-    expect(result.comments.nodes[0].user.displayName).toBe("Ada");
+    expect(result.comments.nodes).toHaveLength(1);
+    expect(result.comments.nodes[0]?.user?.displayName).toBe("Ada");
     expect(client.request).toHaveBeenCalledWith(
       GetIssueByIdentifierWithCommentsDocument,
       {

tsconfig.json

@@ -25,9 +25,8 @@
   "exclude": [
     "node_modules",
     "dist",
-    // Tests excluded from TypeScript compilation to prevent them from
-    // being compiled into dist/. Tests are type-checked and validated
-    // by Vitest at runtime, which provides sufficient type safety.
+    // Tests are excluded from the production build config because
+    // tsconfig.test.json handles test-only type-checking with no emit.
     "tests",
     "**/*.test.ts",
     "**/*.spec.ts",

tsconfig.test.json

@@ -0,0 +1,16 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "rootDir": ".",
+    "noEmit": true,
+    "types": ["node", "vitest/globals"]
+  },
+  "include": [
+    "src/**/*",
+    "tests/**/*",
+    "vitest.base.config.ts",
+    "vitest.config.ts",
+    "vitest.integration.config.ts"
+  ],
+  "exclude": ["node_modules", "dist"]
+}