vello_hybrid: Properly clean up unused resources#1574
Open
LaurenzV wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, an instance of a renderer creates a number of resources (vertex arrays, cached frame buffers), but they are never actually destroyed when the renderer is destroyed. This is usually not a huge problem because the browser garbage collector is likely to pick them up at some point, but it's still bad practice and there is no guarantee was to when this happens. I noticed this when trying
vello_bench2on my tablet, where I wanted to create a new fresh renderer for each benchmark, but at some point the browser would just crash. It is also a best practice to do so.This PR proposes to create thin wrapper types around WebGL resources, where we add a
Dropimplementation that destroys them in WebGL. I admittedly haven't tested on my tablet whether this fixes it (because I switched vello_bench2 to a different approach), but conceptually this should work. 🤔 And it doesn't break the existingnative_webglexample.