glifo: Add basic sanity unit tests for atlas caching#1630
Merged
Conversation
grebmeg
approved these changes
May 21, 2026
Collaborator
grebmeg
left a comment
grebmeg
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding tests!
| fn bitmap_glyph_is_not_cached_when_atlas_cache_is_disabled() { | ||
| ensure_no_cache(TestGlyphKind::Bitmap); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Maybe it’s worth adding tests for stroke outlines to verify that they are not cached, regardless of whether caching is enabled or disabled?
laurenz-canva
force-pushed
the
laurenz/atlas_tests
branch
from
5ad5ec1 to
c9669e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As was evidenced in #1605, it is pretty easy to make changes to the caching logic and then accidentally break the whole caching mechanism.
To hopefully provide some safe-guarding against this, this PR adds 6 unit tests, each ensuring that the different configurations for outline/bitmap/COLR glyphs result in the expected usage of the cache. In case atlas caching is disabled, the cache should stay untouched. In case it's enabled, the glyphs should actually end up landing in the cache.