vello_cpu: Support custom atlas size#1658
Conversation
324bc59 to
0820789
Compare
|
I can get behind configuring the atlas size, but not why you want to expose before_render/after_render? This is supposed to be abstracted away from the user. |
|
Oh, I see now this is in parley… I believe this is still using an older version of vello CPU, so the code hasn’t been updated yet. It should be possible to remove all of this. |
|
Another scenario is that after rendering, we can pass |
dd48b07 to
384f82f
Compare
I hope there is a more concise way. After rendering, cache it into GlyphAtlas, and subsequent users can easily obtain data from |
67bc973 to
e9bd487
Compare
|
By the way, I do want to warn you that the atlas caching API is still experimental and not meant for production use yet. While it seems to work, there are still a number of issues to resolve, especially around performance when zooming. |
e9bd487 to
aa109c3
Compare
Ok. I'll give feedback if there are any problems. Thanks. |
087ab29 to
6aef176
Compare
Currently, the atlas size is not customizable and
DEFAULT_GLYPH_ATLAS_SIZEcan cause excessive memory usage.And exposeResources::before_renderResources::after_rendermethods, so this part of code can be simplified.The behavior of
vello_cpu Resourcesandvello_hybrid Resourceswill be more consistent.