Upgrade sarama to support Kafka 2.0.0 (#440)#447
Merged
Conversation
haeuserd
commented
Sep 10, 2018
haeuserd
commented
Contributor
- Upgrade Shopify/sarama to 1.18.0
* Upgrade Shopify/sarama to 1.18.0
Closed
Merged
|
i need this :) |
|
+1 |
|
I've rebuilt our burrow install using haeuserd:kafka-2.0 and everything seems to be working again. Would very much prefer to migrate back to this repo once this is merged (no offense @haeuserd !!! :-) ) |
Contributor
|
sarama 1.19 is available |
|
@bai can you jump in here and take a look at this one? |
Collaborator
Yep this is on my plate; this change has been tested already so LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.