Remove flaky sleeps from PipelineOperatorAppTest#226
Merged
Conversation
stopSuppressesFailureHandler had a race: the controller-release thread and stop() ran concurrently, so the controller's run() could return before stopRequested was set, firing the failure handler from the wrapper's finally block. Tie the release to the fake manager's shutdown() instead — stop() now deterministically sets stopRequested before releasing the controller. Also drop two unnecessary Thread.sleep(50)s: - stopShutsDownControllerManagerAndUnblocksAwaitTermination: replaced the post-start sleep with a Thread.State poll so we only assert awaitTermination is blocking once the waiter thread is actually in a waiting state. - multipleControllerExitsFireHandlerOnlyOnce: removed entirely. awaitTermination() already waits for every wrapped controller's finally block (including reportFailure) to complete.
Code Coverage
|
ryannedolan
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stopSuppressesFailureHandler had a race: the controller-release thread and stop() ran concurrently, so the controller's run() could return before stopRequested was set, firing the failure handler from the wrapper's finally block. Tie the release to the fake manager's shutdown() instead — stop() now deterministically sets stopRequested before releasing the controller.
Also drop two unnecessary Thread.sleep(50)s: