Disallow setting retention on non-partitioned columns#588
Open
jiang95-dev wants to merge 1 commit into
Open
Conversation
cbb330
requested changes
May 16, 2026
Collaborator
cbb330
left a comment
cbb330
left a comment
There was a problem hiding this comment.
it looks like this change will invoke per INSERT to table, so could suddenly cause failed writer pipelines.
can we:
- (ideal) make backup feature succeed even for tables with this partition scheme
- (suitable) prevent alter table only in order to stop the bleed?
| // Retention DELETE must be satisfiable by partition pruning. When the table is not | ||
| // time-partitioned, the retention column must be one of the clustering columns; | ||
| // otherwise the retention job would degrade into a row-level rewrite (or fail outright | ||
| // when backup is enabled). |
Collaborator
There was a problem hiding this comment.
please add why it fails backup and the impact of a failing backup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up PR on #552. Disallow setting retention on non-partitioned columns because it is not a metadata-only delete.
Changes
For all the boxes checked, please include additional details of the changes made in this pull request.
Testing Done
For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.
Additional Information
For all the boxes checked, include additional details of the changes made in this pull request.