Fix Gateway API CRD validation to run in Linkerd check --pre instead of install#15050
Fix Gateway API CRD validation to run in Linkerd check --pre instead of install#15050gurpreet-singh-ji wants to merge 5 commits intolinkerd:mainfrom
Conversation
|
@gurpreet-singh-ji it seems like this broke tests. you can run these yourself by running |
|
|
||
| return defaultValues | ||
| } | ||
|
|
There was a problem hiding this comment.
nit: we shouldn't make unrelated whitespace changes.
| // if they are installed and managed by Linkerd, we cannot uninstall them | ||
| return errors.New("Linkerd is providing GW API, but your current install configuration will remove it") |
There was a problem hiding this comment.
why is the comment deleted, if there are not changes to the corresponding code?
| if installing { | ||
| // if they are installed but are external, we cannot be installing as well | ||
| return errors.New("Linkerd cannot install the Gateway API CRDs because they are already installed by an external source. Please set `installGatewayAPI` to `false`.") |
…e test cases by running go test ./...
fixing the whitspaces and restoring old comments and also pass all th…
Fix Gateway API validation logic to avoid overwriting install state
|
Hi @cratelyn, thanks for the feedback! I’ve fixed the test issues, restored the comments, and removed unrelated changes. Would appreciate another review when you get time. Thanks! |
|
it seems like tests still haven't been run. i think it's unlikely that we're disposed to accept this pull request. thank you for your time, i'm sorry about that. |
3 participants
Problem:
Gateway API CRD validation was incorrectly running during linkerd install instead of during linkerd check --pre, causing confusion and unnecessary failures before installation.
Solution:
Moved Gateway API CRD validation logic to execute during linkerd check --pre.
Updated relevant checks and messages to reflect the new validation flow.
Validation:
Ran linkerd check --pre and confirmed Gateway API CRDs are properly validated.