Refresh model files for 1.11.0-rc3#253
Conversation
amc-corey-cox
left a comment
amc-corey-cox
left a comment
There was a problem hiding this comment.
This looks good to me. Claude pointed out to me that we now have a few files named in linkml_files.py that we just deleted so they now don't exist. Might be nice to clean that up but it's just a nit. This is ready to go.
|
One minor comment above about |
I did the change now but it unfortunately wont permeate all the way through until the NEXT release. This is because some of the generated artefacts use the metamodel version vendored into the meta.py INSIDE the runtime. Once this is merged and updated in the runtime, this loop will close a bit more, but it is an annoying side effect that the "metamodel version" used to generate the metamodel is NOT the same as the meta model version being updated. |
| """ | ||
| Determines how a linear contiguous representation of the elements of an array map to array indices | ||
| """ | ||
| COLUMN_MAJOR_ARRAY_ORDER = PermissibleValue( |
There was a problem hiding this comment.
Sorry, I'm looking at this in more detail now. Claude flagged this -- PermissibleValue is not imported or defined in this file. Unless I am missing something, I don't think this file can be imported. Is that OK? The top-level comment says "model is not intended to be imported directly". I don't fully understand how this file is used, and I suppose since this is the first time it is generated, it hasn't been used at all!
| description="""An array layout option in which the elements in each row is stored in consecutive positions, or any generalization thereof to dimensionality greater than 2""", | ||
| meaning=GOM["rowMajorArray"]) | ||
|
|
||
| _defn = EnumDefinition( |
| class_name: ClassVar[str] = "NDArray" | ||
| class_model_uri: ClassVar[URIRef] = LINKML.NDArray | ||
|
|
||
| elements: Union[Union[dict, Any], list[Union[dict, Any]]] = None |
There was a problem hiding this comment.
The type hint says that elements is required but there is no
if self._is_empty(self.elements):
self.MissingRequiredField("elements")like in DataArray.__post_init__. Probably an issue with pythongen.py but just flagging it as something that appears to be missing. Not blocking if this file isn't used anyway
amc-corey-cox
left a comment
amc-corey-cox
left a comment
There was a problem hiding this comment.
This looks good to me now.
|
@rly I filed a follow up issue for all your observations and assigned @amc-corey-cox : linkml/linkml#3483 These were broken before - PR just surfaces the brokenness - and we need to RC release out now! THANKS 1 million for the reviews! |
3 participants
Regenerates the generated artifacts under
linkml_model/against the current source schemas inlinkml_model/model/schema/for the upcoming 1.11.0-rc3 release. Two real changes plus some cleanup:Picks up the
permissivle→permissibletypo fix from Fix mistyping in MatchQuery description #249. That PR fixed the typo inmeta.yamlbut didn't refresh the downstream generated artifacts. This PR propagates the fix intometa.py,jsonld/meta.jsonld,jsonschema/meta.schema.json,protobuf/meta.proto,owl/meta.owl.ttl,shacl/meta.shacl.ttl, andsqlschema/meta.sql.Populates
linkml_model/array.py. The file existed but was empty —array.yamlhas been part of the schema source for a while but the Python module was never generated from it (see Fix equals_string on enum-ranged array_linearization_order #251). Now it ships properly (285 lines).Revives stale
linkml_model/rdf/andlinkml_model/sqlddl/. These were removed from the gen-project defaults at some time back in 2023 - I hereby add them back.