Open
Conversation
TypeORM 0.3.x no longer accepts a raw ID in findOne(). Migrate to
findOne({ where: { id } }) and findOne({ where: { id }, relations })
so the test suite compiles and passes.
Made-with: Cursor
Made-with: Cursor
- Downgrade sqlite3 to ^5.1.7 to satisfy typeorm peer dependency - Add tsconfig.test.json so ts-jest resolves @types/jest globals - Point jest.config transform at the test tsconfig - Replace pnpm-lock.yaml with package-lock.json for npm ci in CI Made-with: Cursor
- Add explicit rootDir for TS6 requirement (TS5011) - Add types: ["node"] since TS6 no longer auto-includes @types - Bump lib to es2018 for AsyncGenerator support needed by typeorm Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getRepository(this.entity).save(entity);returns a promise that was not being awaited. So this caused an issue trying when working postGenerators because the entity was not always guaranteed to be persisted.