Skip to content

TPT-4303: Support alert definition entities and update new fields for creation#781

Open
yec-akamai wants to merge 4 commits intolinode:devfrom
yec-akamai:TPT-4303/20k-api-change
Open

TPT-4303: Support alert definition entities and update new fields for creation#781
yec-akamai wants to merge 4 commits intolinode:devfrom
yec-akamai:TPT-4303/20k-api-change

Conversation

@yec-akamai
Copy link
Copy Markdown
Contributor

@yec-akamai yec-akamai commented Apr 15, 2026

📝 Description

Add support for alert definition scope and regions. Introduce a new list module to retrieve entities associated with an alert definition.

✔️ How to Test

make test-int TEST_SUITE=monitor_services_alert_definition 
make test-int TEST_SUITE=monitor_alert_definition_entities_list

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for alert-definition scoping/regions and introduces a new list module to retrieve entities associated with an alert definition, alongside updating integration coverage and generated documentation samples.

Changes:

  • Extend monitor_services_alert_definition to accept scope and regions and pass them through on create.
  • Add new module monitor_alert_definition_entities_list plus an integration target and docs for it.
  • Refresh alert-definition sample responses across doc fragments and module docs (including scope, regions, and entities).

Reviewed changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/integration/targets/monitor_services_alert_definition/tasks/main.yaml Adds scope/regions to create flow and asserts returned fields.
tests/integration/targets/monitor_alert_definition_entities_list/tasks/main.yaml New integration target validating the new entities-list module returns a list.
requirements.txt Switches linode_api4 dependency from PyPI range to git @dev.
plugins/modules/monitor_services_alert_definition.py Adds scope/regions params and includes them in create request payload.
plugins/modules/monitor_alert_definition_entities_list.py New list module for alert definition entities (beta endpoint).
plugins/module_utils/doc_fragments/alert_definitions_list.py Updates list sample response to include new fields/shape.
plugins/module_utils/doc_fragments/alert_definitions_by_service_type_list.py Updates by-service-type list sample response to include new fields/shape.
plugins/module_utils/doc_fragments/alert_definition_info.py Updates info sample response to include new fields/shape.
plugins/module_utils/doc_fragments/alert_definition_entities_list.py Adds examples and result samples for the new entities-list module.
plugins/module_utils/doc_fragments/alert_definition.py Updates alert definition sample response to include new fields/shape.
docs/modules/monitor_services_alert_definition_list.md Updates sample response JSON to match current API shape.
docs/modules/monitor_services_alert_definition_info.md Updates sample response JSON to match current API shape.
docs/modules/monitor_services_alert_definition_by_service_type_list.md Updates sample response JSON to match current API shape.
docs/modules/monitor_services_alert_definition.md Documents new scope/regions params and updates sample response JSON.
docs/modules/monitor_alert_definition_entities_list.md Adds generated docs page for the new module.
README.md Adds the new module to the module index table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread plugins/modules/monitor_alert_definition_entities_list.py
Comment thread docs/modules/monitor_alert_definition_entities_list.md
Comment thread docs/modules/monitor_alert_definition_entities_list.md
@yec-akamai yec-akamai added the new-feature for new features in the changelog. label Apr 15, 2026
@yec-akamai yec-akamai marked this pull request as ready for review April 15, 2026 15:47
@yec-akamai yec-akamai requested review from a team as code owners April 15, 2026 15:47
@yec-akamai yec-akamai requested review from lgarber-akamai and mawilk90 and removed request for a team April 15, 2026 15:47
@yec-akamai yec-akamai changed the title TPT-4303: init TPT-4303: Support alert definition entities and update new fields Apr 15, 2026
@yec-akamai yec-akamai changed the title TPT-4303: Support alert definition entities and update new fields TPT-4303: Support alert definition entities and update new fields for creation Apr 15, 2026
@mawilk90 mawilk90 requested review from psnoch-akamai and removed request for mawilk90 April 16, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants