TPT-3529: Handle non-existing rules for firewall updates#782
Open
ezilber-akamai wants to merge 2 commits intolinode:devfrom
Open
TPT-3529: Handle non-existing rules for firewall updates#782ezilber-akamai wants to merge 2 commits intolinode:devfrom
ezilber-akamai wants to merge 2 commits intolinode:devfrom
Conversation
ezilber-akamai
requested review from
ckulinsk,
Copilot and
jriddle-linode
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes linode.cloud.firewall update behavior so that user-supplied firewall rules with new labels are appended (rather than being ignored due to diffing against a mutated “remote” ruleset).
Changes:
- Update firewall rule reconciliation to amend existing remote rules and append any local rules that don’t exist remotely.
- Extend the
firewall_updateintegration suite with a scenario that appends a new inbound rule viastate: update. - Minor whitespace cleanup in the integration playbook.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
plugins/modules/firewall.py |
Refactors _update_rules to avoid mutating remote rules during diffing and to append missing labeled rules during updates. |
tests/integration/targets/firewall_update/tasks/main.yaml |
Cleans up whitespace and adds an integration case asserting that a new inbound rule can be appended on update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fixed firewall update behavior to append non-existing rules.
✔️ How to Test
make test-int TEST_SUITE="firewall_update"