Skip to content

chore: return notFound when disk isn't attached#393

Closed
guilhem wants to merge 1 commit into
mainfrom
notfound
Closed

chore: return notFound when disk isn't attached#393
guilhem wants to merge 1 commit into
mainfrom
notfound

Conversation

@guilhem

@guilhem guilhem commented Mar 11, 2025

Copy link
Copy Markdown
Contributor

https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/5a645a4b2fe29a52bba3305365c5918d049f1cf0/pkg/csi/service/osutils/linux_os_utils.go#L870

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@guilhem
guilhem requested review from a team as code owners March 11, 2025 13:53
@codecov

codecov Bot commented Mar 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.53%. Comparing base (bc68bba) to head (611e6a5).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   70.53%   70.53%           
=======================================
  Files          24       24           
  Lines        2118     2118           
=======================================
  Hits         1494     1494           
  Misses        496      496           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guilhem

guilhem commented Mar 12, 2025

Copy link
Copy Markdown
Contributor Author

⚠️ spec is unclear about what to do here.
Looking at kubernetes code, both return have same action.
This PR could be ignored for now

@guilhem

guilhem commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

Surpassed by #539

@guilhem guilhem closed this Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant