Skip to content

TPT-3499: Support NodeBalancer lke_cluster field#933

Open
jbilskiAkam wants to merge 2 commits intolinode:mainfrom
jbilskiAkam:feature/TPT-3499-linodego-support-nodebalancer-lke_cluster-and-type-fields
Open

TPT-3499: Support NodeBalancer lke_cluster field#933
jbilskiAkam wants to merge 2 commits intolinode:mainfrom
jbilskiAkam:feature/TPT-3499-linodego-support-nodebalancer-lke_cluster-and-type-fields

Conversation

@jbilskiAkam
Copy link
Copy Markdown

📝 Description

This PR adds support for the new read-only field lke_cluster in the NodeBalancer struct.

✔️ How to Test

To run relevant unit tests use:

make test-unit

@jbilskiAkam jbilskiAkam marked this pull request as ready for review April 14, 2026 13:41
Copilot AI review requested due to automatic review settings April 14, 2026 13:41
@jbilskiAkam jbilskiAkam requested review from a team as code owners April 14, 2026 13:41
@jbilskiAkam jbilskiAkam requested review from ckulinsk and jriddle-linode and removed request for a team April 14, 2026 13:41
@jbilskiAkam jbilskiAkam added the new-feature for new features in the changelog. label Apr 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in linodego for the new read-only lke_cluster field returned on NodeBalancer objects, along with unit-test coverage and updated fixtures.

Changes:

  • Add LKECluster field to NodeBalancer and introduce NodeBalancerLKECluster response struct.
  • Extend unit tests to validate unmarshalling for both null and populated lke_cluster.
  • Update/add JSON fixtures to include the new lke_cluster field.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
nodebalancer.go Adds NodeBalancer.LKECluster plus the NodeBalancerLKECluster type for response unmarshalling.
test/unit/nodebalancer_test.go Expands GET/LIST tests to assert LKECluster is correctly decoded.
test/unit/fixtures/nodebalancers_list.json Updates list fixture to include lke_cluster for both null and object cases.
test/unit/fixtures/nodebalancer_get.json Updates get fixture to include "lke_cluster": null.
test/unit/fixtures/nodebalancer_get_with_lke_cluster.json New fixture representing a NodeBalancer with a populated lke_cluster.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread nodebalancer.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants