TPT-3499: Support NodeBalancer lke_cluster field#933
Open
jbilskiAkam wants to merge 2 commits intolinode:mainfrom
Open
TPT-3499: Support NodeBalancer lke_cluster field#933jbilskiAkam wants to merge 2 commits intolinode:mainfrom
jbilskiAkam wants to merge 2 commits intolinode:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support in linodego for the new read-only lke_cluster field returned on NodeBalancer objects, along with unit-test coverage and updated fixtures.
Changes:
- Add
LKEClusterfield toNodeBalancerand introduceNodeBalancerLKEClusterresponse struct. - Extend unit tests to validate unmarshalling for both
nulland populatedlke_cluster. - Update/add JSON fixtures to include the new
lke_clusterfield.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
nodebalancer.go |
Adds NodeBalancer.LKECluster plus the NodeBalancerLKECluster type for response unmarshalling. |
test/unit/nodebalancer_test.go |
Expands GET/LIST tests to assert LKECluster is correctly decoded. |
test/unit/fixtures/nodebalancers_list.json |
Updates list fixture to include lke_cluster for both null and object cases. |
test/unit/fixtures/nodebalancer_get.json |
Updates get fixture to include "lke_cluster": null. |
test/unit/fixtures/nodebalancer_get_with_lke_cluster.json |
New fixture representing a NodeBalancer with a populated lke_cluster. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…er-lke_cluster-and-type-fields
zliang-akamai
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds support for the new read-only field
lke_clusterin the NodeBalancer struct.✔️ How to Test
To run relevant unit tests use: