Skip to content

fix(middlewares): enhance logging in LoginRequired middleware to incl… #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yyg-max merged 2 commits into from
May 13, 2026
Merged

fix(middlewares): enhance logging in LoginRequired middleware to incl… #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b709261
fix(middlewares): enhance logging in LoginRequired middleware to incl…
OrenZhang May 13, 2026
fff55b4
fix(middlewares): enhance audit logging in LoginRequired middleware w…
OrenZhang May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions internal/apps/oauth/middlewares.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,26 @@
package oauth

import (
"encoding/json"
"net/http"

"github.com/gin-gonic/gin"
"github.com/linux-do/cdk/internal/db"
"github.com/linux-do/cdk/internal/logger"
"github.com/linux-do/cdk/internal/otel_trace"
"net/http"
)

type loginRequiredAuditLog struct {
UserID uint64 `json:"user_id"`
Username string `json:"username"`
ClientIP string `json:"client_ip"`
Method string `json:"method"`
Path string `json:"path"`
RequestURI string `json:"request_uri"`
UserAgent string `json:"user_agent"`
Referer string `json:"referer"`
}

func LoginRequired() gin.HandlerFunc {
return func(c *gin.Context) {
// init trace
Expand All @@ -53,8 +66,23 @@ func LoginRequired() gin.HandlerFunc {
return
}

// log
logger.InfoF(ctx, "[LoginRequired] %d %s", user.ID, user.Username)
auditLog := loginRequiredAuditLog{
UserID: user.ID,
Username: user.Username,
ClientIP: c.ClientIP(),
Method: c.Request.Method,
Path: c.Request.URL.Path,
RequestURI: c.Request.RequestURI,
UserAgent: c.Request.UserAgent(),
Referer: c.Request.Referer(),
}
auditJSON, err := json.Marshal(auditLog)
if err != nil {
logger.ErrorF(ctx, "[LoginRequiredAudit] marshal failed: %v", err)
logger.InfoF(ctx, "[LoginRequiredAudit] %s %d %s", c.ClientIP(), user.ID, user.Username)
} else {
logger.InfoF(ctx, "[LoginRequiredAudit] %s", auditJSON)
}

// set user info
SetUserToContext(c, &user)
Expand Down
Loading