Merged
Conversation
A user can enable WORKFLOWS_TESTS alongside BOOTLINUX_BUILDER, which prevents KDEVOPS_WORKFLOW_NAME from being set to "linux". This causes the wrong hosts template to be selected, generating an unusable hosts file. Adding a dependency on !BOOTLINUX_BUILDER to WORKFLOWS_TESTS ensures the two options are mutually exclusive. Generated-by: Claude AI Fixes: 40df5ef ("gen_hosts: use kdevops_workflow_name directly for template selection") Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
The linux.j2 template uses kdevops_hosts_prefix but should use kdevops_host_prefix to match all other workflow templates. The former is a role default with a static value of "kdevops", while the latter comes from Kconfig and reflects the user's configured host prefix. This typo causes the generated hosts file to always use "kdevops-builder" regardless of the configured KDEVOPS_HOST_PREFIX. Fixes: 24c71ee ("gen_hosts: Get the 'separate kernel builder' workflow working again") Generated-by: Claude AI Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
The builder.j2 template became orphaned when commit 40df5ef refactored template selection to use workflows/<name>.j2 files. The workflows/linux.j2 template now serves this purpose. Remove the dead code. Generated-by: Claude AI Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get "separate builder" workflow working again.