Skip to content

codetag: Avoid unused alloc_tags sections/symbols#64

Open
modules-kpd-app[bot] wants to merge 2 commits intomodules-next_basefrom
series/943567=>modules-next
Open

codetag: Avoid unused alloc_tags sections/symbols#64
modules-kpd-app[bot] wants to merge 2 commits intomodules-next_basefrom
series/943567=>modules-next

Conversation

@modules-kpd-app
Copy link

@modules-kpd-app modules-kpd-app bot commented Mar 18, 2025

Pull request for series with
subject: codetag: Avoid unused alloc_tags sections/symbols
version: 1
url: https://patchwork.kernel.org/project/linux-modules/list/?series=943567

@modules-kpd-app
Copy link
Author

modules-kpd-app bot commented Mar 18, 2025

Upstream branch: 085c5e3
series: https://patchwork.kernel.org/project/linux-modules/list/?series=943567
version: 1

@modules-kpd-app modules-kpd-app bot force-pushed the modules-next_base branch from 7c2b408 to 2996654 Compare April 7, 2025 01:58
@modules-kpd-app
Copy link
Author

modules-kpd-app bot commented Apr 7, 2025

Upstream branch: 897c0b4
series: https://patchwork.kernel.org/project/linux-modules/list/?series=943567
version: 1

@modules-kpd-app modules-kpd-app bot force-pushed the series/943567=>modules-next branch from 4958372 to 2109de9 Compare April 7, 2025 01:59
@modules-kpd-app modules-kpd-app bot force-pushed the modules-next_base branch from 2996654 to d4037eb Compare April 7, 2025 14:12
@modules-kpd-app
Copy link
Author

modules-kpd-app bot commented Apr 7, 2025

Upstream branch: b464e57
series: https://patchwork.kernel.org/project/linux-modules/list/?series=943567
version: 1

@modules-kpd-app modules-kpd-app bot force-pushed the series/943567=>modules-next branch from 2109de9 to 3f6714c Compare April 7, 2025 14:13
@modules-kpd-app modules-kpd-app bot force-pushed the modules-next_base branch from d4037eb to 39f16b8 Compare May 5, 2025 08:22
@modules-kpd-app modules-kpd-app bot force-pushed the modules-next_base branch from 39f16b8 to d6fb02c Compare May 18, 2025 12:05
@modules-kpd-app
Copy link
Author

modules-kpd-app bot commented May 18, 2025

Upstream branch: a0b018a
series: https://patchwork.kernel.org/project/linux-modules/list/?series=943567
version: 1

@modules-kpd-app modules-kpd-app bot force-pushed the series/943567=>modules-next branch from 3f6714c to bf57d64 Compare May 18, 2025 12:05
@modules-kpd-app modules-kpd-app bot force-pushed the modules-next_base branch from d6fb02c to b788ac1 Compare June 2, 2025 09:03
@modules-kpd-app
Copy link
Author

modules-kpd-app bot commented Jun 2, 2025

Upstream branch: a0b018a
series: https://patchwork.kernel.org/project/linux-modules/list/?series=943567
version: 1

@petrpavlu
codetag: Avoid unused alloc_tags sections/symbols
b78d155 
With CONFIG_MEM_ALLOC_PROFILING=n, vmlinux and all modules unnecessarily
contain the symbols __start_alloc_tags and __stop_alloc_tags, which define
an empty range. In the case of modules, the presence of these symbols also
forces the linker to create an empty .codetag.alloc_tags section.

Update codetag.lds.h to make the data conditional on
CONFIG_MEM_ALLOC_PROFILING.

Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
Reviewed-by: Kent Overstreet <kent.overstreet@linux.dev>
Reviewed-by: Suren Baghdasaryan <surenb@google.com>
@modules-kpd-app modules-kpd-app bot force-pushed the series/943567=>modules-next branch from bf57d64 to b78d155 Compare June 2, 2025 09:03
@modules-kpd-app modules-kpd-app bot force-pushed the modules-next_base branch from cbdca0b to 6a1a12c Compare June 25, 2025 20:39
@modules-kpd-app
Copy link
Author

modules-kpd-app bot commented Jun 25, 2025

Upstream branch: a0b018a
series: https://patchwork.kernel.org/project/linux-modules/list/?series=973440
version: 2

Pull request is NOT updated. Failed to apply https://patchwork.kernel.org/project/linux-modules/list/?series=973440
error message:

Cmd('git') failed due to: exit code(128)
  cmdline: git am --3way
  stdout: 'Applying: codetag: Avoid unused alloc_tags sections/symbols
Patch failed at 0001 codetag: Avoid unused alloc_tags sections/symbols'
  stderr: 'error: sha1 information is lacking or useless (include/asm-generic/codetag.lds.h).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"'

conflict:

@modules-kpd-app modules-kpd-app bot force-pushed the modules-next_base branch 2 times, most recently from 6381fa5 to aaa7ece Compare June 26, 2025 18:03
@dagomez137 dagomez137 force-pushed the modules-next_base branch from aaa7ece to b4d1c4e Compare July 4, 2025 13:33
@dagomez137 dagomez137 force-pushed the modules-next_base branch from b4d1c4e to 61dc34e Compare July 4, 2025 19:48
@modules-kpd-app modules-kpd-app bot force-pushed the modules-next_base branch 2 times, most recently from 1df8185 to 9aab33d Compare July 8, 2025 19:00
@dagomez137 dagomez137 force-pushed the modules-next_base branch from 9aab33d to 99d099e Compare July 8, 2025 19:46
@modules-kpd-app modules-kpd-app bot force-pushed the modules-next_base branch from 99d099e to 3aed49d Compare July 8, 2025 19:56
dagomez137 pushed a commit that referenced this pull request Sep 22, 2025
@hyperenju @anguy11
igc: don't fail igc_probe() on LED setup error
528eb4e 
When igc_led_setup() fails, igc_probe() fails and triggers kernel panic
in free_netdev() since unregister_netdev() is not called. [1]
This behavior can be tested using fault-injection framework, especially
the failslab feature. [2]

Since LED support is not mandatory, treat LED setup failures as
non-fatal and continue probe with a warning message, consequently
avoiding the kernel panic.

[1]
 kernel BUG at net/core/dev.c:12047!
 Oops: invalid opcode: 0000 [#1] SMP NOPTI
 CPU: 0 UID: 0 PID: 937 Comm: repro-igc-led-e Not tainted 6.17.0-rc4-enjuk-tnguy-00865-gc4940196ab02 #64 PREEMPT(voluntary)
 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
 RIP: 0010:free_netdev+0x278/0x2b0
 [...]
 Call Trace:
  <TASK>
  igc_probe+0x370/0x910
  local_pci_probe+0x3a/0x80
  pci_device_probe+0xd1/0x200
 [...]

[2]
 #!/bin/bash -ex

 FAILSLAB_PATH=/sys/kernel/debug/failslab/
 DEVICE=0000:00:05.0
 START_ADDR=$(grep " igc_led_setup" /proc/kallsyms \
         | awk '{printf("0x%s", $1)}')
 END_ADDR=$(printf "0x%x" $((START_ADDR + 0x100)))

 echo $START_ADDR > $FAILSLAB_PATH/require-start
 echo $END_ADDR > $FAILSLAB_PATH/require-end
 echo 1 > $FAILSLAB_PATH/times
 echo 100 > $FAILSLAB_PATH/probability
 echo N > $FAILSLAB_PATH/ignore-gfp-wait

 echo $DEVICE > /sys/bus/pci/drivers/igc/bind

Fixes: ea57870 ("igc: Add support for LEDs on i225/i226")
Signed-off-by: Kohei Enju <enjuk@amazon.com>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
Tested-by: Mor Bar-Gabay <morx.bar.gabay@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
dagomez137 pushed a commit that referenced this pull request Oct 20, 2025
@davejiang
cxl/features: Add check for no entries in cxl_feature_info
a375246 
cxl EDAC calls cxl_feature_info() to get the feature information and
if the hardware has no Features support, cxlfs may be passed in as
NULL.

[   51.957498] BUG: kernel NULL pointer dereference, address: 0000000000000008
[   51.965571] #PF: supervisor read access in kernel mode
[   51.971559] #PF: error_code(0x0000) - not-present page
[   51.977542] PGD 17e4f6067 P4D 0
[   51.981384] Oops: Oops: 0000 [#1] SMP NOPTI
[   51.986300] CPU: 49 UID: 0 PID: 3782 Comm: systemd-udevd Not tainted 6.17.0dj
test+ #64 PREEMPT(voluntary)
[   51.997355] Hardware name: <removed>
[   52.009790] RIP: 0010:cxl_feature_info+0xa/0x80 [cxl_core]

Add a check for cxlfs before dereferencing it and return -EOPNOTSUPP if
there is no cxlfs created due to no hardware support.

Fixes: eb5dfcb ("cxl: Add support to handle user feature commands for set feature")
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
@modules-kpd-app modules-kpd-app bot force-pushed the modules-next_base branch 4 times, most recently from cdc6b9e to 311def7 Compare October 22, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merge-conflict modules-next new V2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@petrpavlu