Skip to content

nvmetcli: store DHCHAP attributes #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igaw merged 1 commit into from
Jul 15, 2026
Merged

nvmetcli: store DHCHAP attributes #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion nvmet/nvme.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,6 +1144,7 @@ def __init__(self, nqn, mode='any'):
'''
super().__init__()

self.attr_groups = ['dhchap']
self.nqn = nqn
self._path = f"{self.configfs_dir}/hosts/{nqn}"
self._create_in_cfs(mode)
Expand All @@ -1161,11 +1162,13 @@ def setup(cls, t, err_func):
return

try:
Host(t['nqn'])
h = Host(t['nqn'])
except CFSError as e:
err_func(f"Could not create Host object: {e}")
return

h._setup_attrs(t, err_func)

def dump(self):
'''
Returns a dict with the config of the object.
Expand Down
6 changes: 4 additions & 2 deletions nvmet/test_nvmet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,8 @@ def test_save_restore(self):
root = nvme.Root()
root.clear_existing()

nvme.Host(nqn='hostnqn', mode='create')
h = nvme.Host(nqn='hostnqn', mode='create')
h.set_attr('dhchap', 'dhgroup', 'ffdhe2048')

s = nvme.Subsystem(nqn='testnqn', mode='create')
s.add_allowed_host(nqn='hostnqn')
Expand Down Expand Up @@ -503,7 +504,7 @@ def test_save_restore(self):
root.restore_from_file('test.json', True)

# rebuild our view of the world
nvme.Host(nqn='hostnqn', mode='lookup')
h = nvme.Host(nqn='hostnqn', mode='lookup')
s = nvme.Subsystem(nqn='testnqn', mode='lookup')
s2 = nvme.Subsystem(nqn='testnqn2', mode='lookup')
n = nvme.Namespace(s, nsid=42, mode='lookup')
Expand All @@ -518,6 +519,7 @@ def test_save_restore(self):
self.assertEqual(n.get_attr('device', 'path'), NVMET_TEST_DEVICES[0])
self.assertEqual(n.get_attr('device', 'nguid'), nguid)

self.assertEqual(h.get_attr('dhchap', 'dhgroup'), 'ffdhe2048')
self.assertEqual(p.get_attr('addr', 'trtype'), 'loop')
self.assertEqual(p.get_attr('addr', 'adrfam'), 'ipv4')
self.assertEqual(p.get_attr('addr', 'traddr'), '192.168.0.1')
Expand Down
Loading