Disable Nagle for testing (TCP_NODELAY), allow to change message size for socket tests#23
Open
vitalif wants to merge 2 commits intolinux-rdma:masterfrom
Open
Disable Nagle for testing (TCP_NODELAY), allow to change message size for socket tests#23vitalif wants to merge 2 commits intolinux-rdma:masterfrom
vitalif wants to merge 2 commits intolinux-rdma:masterfrom
Conversation
…stead of hard-coded defaults (1 byte and 32K)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Current qperf always uses hard-coded message sizes for tests.
Notably, 1 byte for tcp_lat and 32K for tcp_bw.
Testing latency with 1 byte messages is a bit... incorrect.
It's also incorrect without setting TCP_NODELAY.
This PR fixes both problems.