Skip to content

refactor: comply with Ansible partner certification checks#249

Open
richm wants to merge 1 commit intolinux-system-roles:mainfrom
richm:refactor-comply-with-ansible-partner-cert-checks
Open

refactor: comply with Ansible partner certification checks#249
richm wants to merge 1 commit intolinux-system-roles:mainfrom
richm:refactor-comply-with-ansible-partner-cert-checks

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Apr 1, 2026

prepare for testing with all supported and milestone ansible-test versions

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Build:

  • Add version-specific .sanity-ansible-ignore configuration files for ansible-test 2.18 through 2.21 to align with supported testing versions.

prepare for testing with all supported and milestone ansible-test versions

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 1, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds Ansible sanity ignore configuration files for multiple ansible-test versions to align with Ansible partner certification checks and allow testing across supported and milestone releases.

File-Level Changes

Change Details Files
Introduce version-specific Ansible sanity ignore configuration files to support testing across multiple ansible-test versions.
  • Add a sanity ignore file for ansible-test 2.18 to configure checks that should be skipped for that version.
  • Add a sanity ignore file for ansible-test 2.19 to configure checks that should be skipped for that version.
  • Add a sanity ignore file for ansible-test 2.20 to configure checks that should be skipped for that version.
  • Add a sanity ignore file for ansible-test 2.21 to configure checks that should be skipped for that version.
.sanity-ansible-ignore-2.18.txt
.sanity-ansible-ignore-2.19.txt
.sanity-ansible-ignore-2.20.txt
.sanity-ansible-ignore-2.21.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • If these version-specific .sanity-ansible-ignore-* files are intentionally empty but required by the tooling, consider adding a brief comment line in each (or in a single shared place referenced in the commit message) explaining why they must exist and remain empty to avoid future cleanup as ‘dead’ files.
  • Since multiple ansible-test versions are supported, it may be helpful to note somewhere (e.g., in a top-level config or constants file) which versions require their own ignore file and how new versions should be added, to keep the pattern consistent over time.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- If these version-specific `.sanity-ansible-ignore-*` files are intentionally empty but required by the tooling, consider adding a brief comment line in each (or in a single shared place referenced in the commit message) explaining why they must exist and remain empty to avoid future cleanup as ‘dead’ files.
- Since multiple ansible-test versions are supported, it may be helpful to note somewhere (e.g., in a top-level config or constants file) which versions require their own ignore file and how new versions should be added, to keep the pattern consistent over time.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant