refactor: comply with Ansible partner certification checks#249
Open
richm wants to merge 1 commit intolinux-system-roles:mainfrom
Open
refactor: comply with Ansible partner certification checks#249richm wants to merge 1 commit intolinux-system-roles:mainfrom
richm wants to merge 1 commit intolinux-system-roles:mainfrom
Conversation
prepare for testing with all supported and milestone ansible-test versions Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds Ansible sanity ignore configuration files for multiple ansible-test versions to align with Ansible partner certification checks and allow testing across supported and milestone releases. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If these version-specific
.sanity-ansible-ignore-*files are intentionally empty but required by the tooling, consider adding a brief comment line in each (or in a single shared place referenced in the commit message) explaining why they must exist and remain empty to avoid future cleanup as ‘dead’ files. - Since multiple ansible-test versions are supported, it may be helpful to note somewhere (e.g., in a top-level config or constants file) which versions require their own ignore file and how new versions should be added, to keep the pattern consistent over time.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If these version-specific `.sanity-ansible-ignore-*` files are intentionally empty but required by the tooling, consider adding a brief comment line in each (or in a single shared place referenced in the commit message) explaining why they must exist and remain empty to avoid future cleanup as ‘dead’ files.
- Since multiple ansible-test versions are supported, it may be helpful to note somewhere (e.g., in a top-level config or constants file) which versions require their own ignore file and how new versions should be added, to keep the pattern consistent over time.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepare for testing with all supported and milestone ansible-test versions
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Build: