ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox configuration and qemu test environment naming to be compatible with the latest tox-lsr and tox behavior.

CI:

• Bump tox-lsr version from 3.15.0 to 3.16.0 across GitHub Actions workflows.
• Rename qemu and container ansible-core tox environments in the qemu-kvm integration workflow from major.minor to major-minor format.

Documentation:

• Update contributing guide example to use the new qemu tox environment name format.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Renames tox qemu/container test environments from dot-separated to dash-separated ansible-core version identifiers to avoid tox 4.49’s Python version parsing issue, and updates all GitHub workflows and documentation to use tox-lsr 3.16.0 and the new environment names.

Flow diagram for tox environment selection with dash-separated ansible-core versions

flowchart TD
    A["Developer runs: tox -e qemu-ansible-core-2-20"] --> B["tox parses environment name"]
    B --> C{"Environment name contains dash-separated version?"}
    C -->|Yes| D["Interpret 2-20 as ansible-core 2.20 identifier, not Python 2.20"]
    C -->|No| E["Potential conflict with tox Python version parsing"]
    D --> F["Create and run qemu-ansible-core-2-20 testenv"]
    F --> G["Execute QEMU-based Ansible tests"]
    E --> H["Fail or misconfigure environment in tox 4.49"]

Loading

File-Level Changes

Change	Details	Files
Update qemu and container GitHub Actions workflows to use dash-separated tox environments and newer tox-lsr version.	Change qemu-ansible-core-X.Y environment names in the matrix to qemu-ansible-core-X-Y. Change container-ansible-core-X.Y environment names in the matrix to container-ansible-core-X-Y. Update tox-lsr installation in the workflow to use version 3.16.0.	.github/workflows/qemu-kvm-integration-tests.yml
Align other CI workflows on tox-lsr 3.16.0.	Bump tox-lsr version from 3.15.0 to 3.16.0 in ansible-lint workflow. Bump tox-lsr version from 3.15.0 to 3.16.0 in ansible-managed-var-comment workflow. Bump tox-lsr version from 3.15.0 to 3.16.0 in ansible-test workflow. Bump tox-lsr version from 3.15.0 to 3.16.0 in python-unit-test workflow.	.github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml .github/workflows/python-unit-test.yml
Update contributor documentation to reference the new tox environment naming scheme.	Change example tox invocation to use qemu-ansible-core-2-20 instead of qemu-ansible-core-2.14, reflecting the dash-separated ansible-core version.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr version is hard-coded in several workflow files; consider defining it in a single reusable place (e.g., a workflow env var or reusable workflow) so future upgrades only need to be made once.
• In contributing.md the example was changed from qemu-ansible-core-2.14 to qemu-ansible-core-2-20; if changing only the separator is intended, you may want to keep the same ansible-core version to avoid implying a different minimum version requirement.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr version is hard-coded in several workflow files; consider defining it in a single reusable place (e.g., a workflow env var or reusable workflow) so future upgrades only need to be made once.
- In contributing.md the example was changed from `qemu-ansible-core-2.14` to `qemu-ansible-core-2-20`; if changing only the separator is intended, you may want to keep the same ansible-core version to avoid implying a different minimum version requirement.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}