ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]

[richm]

tox-lsr 3.17.1 has a fix for the broken container tests

There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed. The connection plugin must be present and the env. var.
must be set in order to run any container tests. The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.

Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to use tox-lsr 3.17.1 and adjust container test execution flags to restore working container-based integration tests.

Bug Fixes:

• Ensure container integration tests always configure required Ansible connection plugins by no longer skipping callback/connection plugin setup between test runs.

CI:

• Bump tox-lsr dependency from 3.17.0 to 3.17.1 across GitHub Actions workflows.
• Tidy qemu-kvm integration test workflow logic, including indentation and removal of the SKIP_CALLBACK_PLUGINS environment flag toggling.

Tests:

• Stabilize container-based integration tests by relying on tox-lsr 3.17.1 and always preparing the necessary plugin environment.

[sourcery-ai]

Hey - I've left some high level feedback:

• The tox-lsr version string is duplicated across several workflows; consider centralizing it via a reusable workflow, environment variable, or action input to keep future version bumps consistent and easier to maintain.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The tox-lsr version string is duplicated across several workflows; consider centralizing it via a reusable workflow, environment variable, or action input to keep future version bumps consistent and easier to maintain.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}