Skip to content

test: ostree requires cronie package for testing#129

Merged
richm merged 1 commit intolinux-system-roles:mainfrom
richm:test-ostree-cronie
Feb 18, 2026
Merged

test: ostree requires cronie package for testing#129
richm merged 1 commit intolinux-system-roles:mainfrom
richm:test-ostree-cronie

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Feb 17, 2026

ostree requires cronie package for testing

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Tests:

  • Add an ostree testing package list file to ensure required packages like cronie are installed for tests.

@richm richm requested a review from spetrosi as a code owner February 17, 2026 19:54
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Feb 17, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a new OSTree testing package manifest to ensure the cronie package is installed when running OSTree-related tests.

File-Level Changes

Change Details Files
Introduce an OSTree testing package list to declare cronie as a required package for tests.
  • Create the .ostree/packages-testing.txt manifest file for OSTree-related testing dependencies
  • List cronie in the OSTree testing package manifest so test environments install it automatically
.ostree/packages-testing.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

ostree requires cronie package for testing

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm force-pushed the test-ostree-cronie branch from 37bfba0 to c817a05 Compare February 17, 2026 21:04
@richm richm merged commit 02c6955 into linux-system-roles:main Feb 18, 2026
30 checks passed
@richm richm deleted the test-ostree-cronie branch February 18, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant