ci: fix yum repos to use devel site instead of old site name [citest_skip]#20
Closed
ci: fix yum repos to use devel site instead of old site name [citest_skip]#20
Conversation
…skip] Some of the older Testing Farm machines refer to the old site name in the yum repos. Ensure that they use the correct site name. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates references from the old trustee_attestation_client name to the new trustee_client name across documentation, CI/testing configuration, and Ansible test variables to align CI and Testing Farm with the current repository and role naming. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In README.md you’ve updated the workflow badge URLs to
trustee_client, but the title (# trustee_attestation_client) and the tox workflow badge image/link still referencetrustee_attestation_client; consider aligning these for a consistent role/repo name. - Renaming the Ansible variables from
__trustee_attestation_client_*to__trustee_client_*may break existing playbooks or includes that reference the old names; if backward compatibility is needed, consider providing aliases or a short transition shim.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In README.md you’ve updated the workflow badge URLs to `trustee_client`, but the title (`# trustee_attestation_client`) and the tox workflow badge image/link still reference `trustee_attestation_client`; consider aligning these for a consistent role/repo name.
- Renaming the Ansible variables from `__trustee_attestation_client_*` to `__trustee_client_*` may break existing playbooks or includes that reference the old names; if backward compatibility is needed, consider providing aliases or a short transition shim.
## Individual Comments
### Comment 1
<location path="plans/README-plans.md" line_range="20" />
<code_context>
-The [tft.yml](https://github.com/linux-system-roles/trustee_attestation_client/blob/main/.github/workflows/tft.yml) workflow runs the above plan and uploads the results to our Fedora storage for public access.
+The [tft.yml](https://github.com/linux-system-roles/trustee_client/blob/main/.github/workflows/tft.yml) workflow runs the above plan and uploads the results to our Fedora storage for public access.
This workflow uses Testing Farm's Github Action [Schedule tests on Testing Farm](https://github.com/marketplace/actions/schedule-tests-on-testing-farm).
## Running Tests
</code_context>
<issue_to_address>
**nitpick (typo):** Capitalize "GitHub" correctly in "Github Action".
Please change "Github Action" to "GitHub Action" to match the official name and keep the docs consistent.
```suggestion
This workflow uses Testing Farm's GitHub Action [Schedule tests on Testing Farm](https://github.com/marketplace/actions/schedule-tests-on-testing-farm).
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
|
||
| The [tft.yml](https://github.com/linux-system-roles/trustee_attestation_client/blob/main/.github/workflows/tft.yml) workflow runs the above plan and uploads the results to our Fedora storage for public access. | ||
| The [tft.yml](https://github.com/linux-system-roles/trustee_client/blob/main/.github/workflows/tft.yml) workflow runs the above plan and uploads the results to our Fedora storage for public access. | ||
| This workflow uses Testing Farm's Github Action [Schedule tests on Testing Farm](https://github.com/marketplace/actions/schedule-tests-on-testing-farm). |
There was a problem hiding this comment.
nitpick (typo): Capitalize "GitHub" correctly in "Github Action".
Please change "Github Action" to "GitHub Action" to match the official name and keep the docs consistent.
Suggested change
| This workflow uses Testing Farm's Github Action [Schedule tests on Testing Farm](https://github.com/marketplace/actions/schedule-tests-on-testing-farm). | |
| This workflow uses Testing Farm's GitHub Action [Schedule tests on Testing Farm](https://github.com/marketplace/actions/schedule-tests-on-testing-farm). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the older Testing Farm machines refer to the old site name in the yum repos.
Ensure that they use the correct site name.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Align project references and CI metadata with the renamed trustee_client role.
Enhancements:
CI:
Documentation: