Skip to content

ci: fix yum repos to use devel site instead of old site name [citest_skip]#20

Closed
richm wants to merge 1 commit intomainfrom
use-devel-site-yum-repo
Closed

ci: fix yum repos to use devel site instead of old site name [citest_skip]#20
richm wants to merge 1 commit intomainfrom
use-devel-site-yum-repo

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Apr 1, 2026

Some of the older Testing Farm machines refer to the old site name in the yum repos.
Ensure that they use the correct site name.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Align project references and CI metadata with the renamed trustee_client role.

Enhancements:

  • Rename internal distribution variable names to match the trustee_client role naming convention.
  • Update README badges and links to reference the trustee_client GitHub workflows and repository.

CI:

  • Adjust Testing Farm workflow plan filter and documentation examples to use the trustee_client identifier and repository URLs.

Documentation:

  • Update contributor and CI plans documentation to point to the trustee_client repository, issues, and workflows instead of the old trustee_attestation_client name.

…skip]

Some of the older Testing Farm machines refer to the old site name in the yum repos.
Ensure that they use the correct site name.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm self-assigned this Apr 1, 2026
@richm richm requested a review from spetrosi as a code owner April 1, 2026 18:05
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 1, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates references from the old trustee_attestation_client name to the new trustee_client name across documentation, CI/testing configuration, and Ansible test variables to align CI and Testing Farm with the current repository and role naming.

File-Level Changes

Change Details Files
Rename remaining trustee_attestation_client references to trustee_client across docs, CI config, and test vars so Testing Farm and CI use the correct project name.
  • Update contributing guide headings and GitHub links to point to the trustee_client repository and issues.
  • Rename Ansible test variables for RHEL-like distributions from _trustee_attestation_client* to _trustee_client* and adjust dependent expressions accordingly.
  • Update Testing Farm plans README to reference the trustee_client repository URLs and example git-url usage.
  • Adjust tft GitHub workflow tmt_plan_filter tag from trustee_attestation_client to trustee_client to match new naming.
  • Update README CI status badges to point to workflows under the trustee_client repository.
contributing.md
tests/vars/rh_distros_vars.yml
plans/README-plans.md
.github/workflows/tft.yml
README.md
plans/test_playbooks_parallel.fmf
.ansible-lint

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • In README.md you’ve updated the workflow badge URLs to trustee_client, but the title (# trustee_attestation_client) and the tox workflow badge image/link still reference trustee_attestation_client; consider aligning these for a consistent role/repo name.
  • Renaming the Ansible variables from __trustee_attestation_client_* to __trustee_client_* may break existing playbooks or includes that reference the old names; if backward compatibility is needed, consider providing aliases or a short transition shim.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In README.md you’ve updated the workflow badge URLs to `trustee_client`, but the title (`# trustee_attestation_client`) and the tox workflow badge image/link still reference `trustee_attestation_client`; consider aligning these for a consistent role/repo name.
- Renaming the Ansible variables from `__trustee_attestation_client_*` to `__trustee_client_*` may break existing playbooks or includes that reference the old names; if backward compatibility is needed, consider providing aliases or a short transition shim.

## Individual Comments

### Comment 1
<location path="plans/README-plans.md" line_range="20" />
<code_context>

-The [tft.yml](https://github.com/linux-system-roles/trustee_attestation_client/blob/main/.github/workflows/tft.yml) workflow runs the above plan and uploads the results to our Fedora storage for public access.
+The [tft.yml](https://github.com/linux-system-roles/trustee_client/blob/main/.github/workflows/tft.yml) workflow runs the above plan and uploads the results to our Fedora storage for public access.
 This workflow uses Testing Farm's Github Action [Schedule tests on Testing Farm](https://github.com/marketplace/actions/schedule-tests-on-testing-farm).

 ## Running Tests
</code_context>
<issue_to_address>
**nitpick (typo):** Capitalize "GitHub" correctly in "Github Action".

Please change "Github Action" to "GitHub Action" to match the official name and keep the docs consistent.

```suggestion
This workflow uses Testing Farm's GitHub Action [Schedule tests on Testing Farm](https://github.com/marketplace/actions/schedule-tests-on-testing-farm).
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.


The [tft.yml](https://github.com/linux-system-roles/trustee_attestation_client/blob/main/.github/workflows/tft.yml) workflow runs the above plan and uploads the results to our Fedora storage for public access.
The [tft.yml](https://github.com/linux-system-roles/trustee_client/blob/main/.github/workflows/tft.yml) workflow runs the above plan and uploads the results to our Fedora storage for public access.
This workflow uses Testing Farm's Github Action [Schedule tests on Testing Farm](https://github.com/marketplace/actions/schedule-tests-on-testing-farm).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (typo): Capitalize "GitHub" correctly in "Github Action".

Please change "Github Action" to "GitHub Action" to match the official name and keep the docs consistent.

Suggested change
This workflow uses Testing Farm's Github Action [Schedule tests on Testing Farm](https://github.com/marketplace/actions/schedule-tests-on-testing-farm).
This workflow uses Testing Farm's GitHub Action [Schedule tests on Testing Farm](https://github.com/marketplace/actions/schedule-tests-on-testing-farm).

@richm richm closed this Apr 1, 2026
@richm richm deleted the use-devel-site-yum-repo branch April 1, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant