Conversation
use latest version of codecov @v6 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAligns documentation, CI metadata, and test variables with the new trustee_client role/repository naming, including updating GitHub URLs, badges, tmt filters, and Ansible test distro variables from trustee_attestation_client to trustee_client. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- There are still references to
trustee_attestation_clientinREADME.md(header text and the tox badge URL) that should be updated totrustee_clientto stay consistent with the rest of this change. - Since the
tmt_plan_filterwas updated to use thetrustee_clienttag, ensure the correspondingplans/test_playbooks_parallel.fmfplan actually defines that tag (and no longer relies ontrustee_attestation_client) so CI filtering continues to work as expected.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- There are still references to `trustee_attestation_client` in `README.md` (header text and the tox badge URL) that should be updated to `trustee_client` to stay consistent with the rest of this change.
- Since the `tmt_plan_filter` was updated to use the `trustee_client` tag, ensure the corresponding `plans/test_playbooks_parallel.fmf` plan actually defines that tag (and no longer relies on `trustee_attestation_client`) so CI filtering continues to work as expected.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use latest version of codecov @v6
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Update project references from trustee_attestation_client to trustee_client across documentation, test variables, and CI configuration.
Enhancements:
Documentation: