ci: tox-lsr 3.17.0 - container test improvements, use ansible 2.20 for fedora 43 [citest_skip]

[richm]

tox-lsr 3.17.0 has some container test improvements - better output, faster runs

Use Ansible 2.20 for qemu/container tests on fedora 43

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI and testing configuration for the trustee_attestation_server role, including newer tooling and correct role naming throughout.

Enhancements:

• Adjust container test execution to reuse requirements and callback plugin setup across runs for faster, cleaner container testing.

CI:

• Use Ansible 2.20 for Fedora 43 qemu and container integration test scenarios.
• Upgrade tox-lsr to version 3.17.0 across CI workflows.
• Update tmt plan filter, GitHub URLs, badges, and weekly CI schedule to reference the trustee_attestation_server role and adjust the weekly CI trigger time.

Documentation:

• Refresh documentation and README links, names, and examples to reference the trustee_attestation_server role instead of the generic template.

Tests:

• Rename internal Red Hat distribution helper variables to be scoped to the trustee_attestation_server role.

[sourcery-ai]

Reviewer's Guide

Updates CI/testing configuration to use tox-lsr 3.17.0, run Fedora 43 qemu/container tests with Ansible 2.20, adjust container test env flags for faster runs, rebrand remaining template references to trustee_attestation_server, and tweak weekly CI schedule and Testing Farm filters.

Flow diagram for Testing Farm tft workflow with updated plan filter and tooling

flowchart TD
  pr[Pull_request_or_push_to_trustee_attestation_server] --> tft_workflow[tft_GitHub_Action_workflow]

  tft_workflow --> setup_tox[tox-lsr_3_17_0_installed]
  tft_workflow --> setup_ansible[Ansible_2_20_selected_for_Fedora_43_qemu_container_tests]

  tft_workflow --> tf_action[Testing_Farm_GitHub_Action]
  tf_action --> plan_filter[tmt_plan_filter_tag_playbooks_parallel_trustee_attestation_server]
  plan_filter --> run_plans[Run_tmt_multihost_plans_on_Fedora_43]

  run_plans --> qemu_tests[qemu_KVM_tests]
  run_plans --> container_tests[Container_based_tests]

  qemu_tests --> results[Testing_results]
  container_tests --> results

  results --> fedora_storage[Upload_results_to_Fedora_storage]
  results --> commit_status[Set_final_commit_status]

Loading

File-Level Changes

Change	Details	Files
Bump tox-lsr to 3.17.0 in all GitHub Actions workflows.	Update tox-lsr version from 3.16.0 to 3.17.0 in qemu-kvm integration tests workflow Update tox-lsr version from 3.16.0 to 3.17.0 in ansible-lint workflow Update tox-lsr version from 3.16.0 to 3.17.0 in ansible-managed-var-comment workflow Update tox-lsr version from 3.16.0 to 3.17.0 in ansible-test workflow	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Use Ansible 2.20 for Fedora 43 qemu and container test scenarios.	Change Fedora 43 qemu env from ansible-core-2-19 to ansible-core-2-20 Change Fedora 43 container env from ansible-core-2-19 to ansible-core-2-20 Change Fedora 43 bootc container env from ansible-core-2-19 to ansible-core-2-20	.github/workflows/qemu-kvm-integration-tests.yml
Adjust container test loop env flags to leverage tox-lsr test improvements.	Remove overrides that disabled container profile/pretty output variables Ensure requirements and callback plugins are not skipped for the first test run Enable skipping of requirements and callback plugins for subsequent test iterations to speed up runs	.github/workflows/qemu-kvm-integration-tests.yml
Replace remaining 'template' role references with 'trustee_attestation_server' in docs, workflows, and vars.	Rename RH distro helper variable names from template_* to trustee_attestation_server_* in test vars Update contribution guide repo URLs and issue links from template to trustee_attestation_server Update Testing Farm tmt plan filter tag from template to trustee_attestation_server Update README badges and links from template to trustee_attestation_server Update plans README GitHub workflow and git-url examples from template to trustee_attestation_server	tests/vars/rh_distros_vars.yml contributing.md .github/workflows/tft.yml README.md plans/README-plans.md
Tweak weekly CI trigger schedule.	Change weekly CI cron from 0 0 * * 6 to 30 23 * * 6	.github/workflows/weekly_ci.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• In README.md, the final workflow badge still points to the template repository (template/workflows/tox/badge.svg); consider updating it to trustee_attestation_server for consistency with the other badges.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In README.md, the final workflow badge still points to the `template` repository (`template/workflows/tox/badge.svg`); consider updating it to `trustee_attestation_server` for consistency with the other badges.

## Individual Comments

### Comment 1
<location path="plans/README-plans.md" line_range="3" />
<code_context>
 # Introduction CI Testing Plans

-Linux System Roles CI runs [tmt](https://tmt.readthedocs.io/en/stable/index.html) test plans in [Testing farm](https://docs.testing-farm.io/Testing%20Farm/0.1/index.html) with the [tft.yml](https://github.com/linux-system-roles/template/blob/main/.github/workflows/tft.yml) GitHub workflow.
+Linux System Roles CI runs [tmt](https://tmt.readthedocs.io/en/stable/index.html) test plans in [Testing farm](https://docs.testing-farm.io/Testing%20Farm/0.1/index.html) with the [tft.yml](https://github.com/linux-system-roles/trustee_attestation_server/blob/main/.github/workflows/tft.yml) GitHub workflow.

 The `plans/test_playbooks_parallel.fmf` plan is a test plan that runs test playbooks in parallel on multiple managed nodes.
</code_context>
<issue_to_address>
**nitpick (typo):** Consider capitalizing "Farm" in "Testing Farm" to match the official service name.

The official name is "Testing Farm" with both words capitalized. Please update the link text accordingly.

```suggestion
Linux System Roles CI runs [tmt](https://tmt.readthedocs.io/en/stable/index.html) test plans in [Testing Farm](https://docs.testing-farm.io/Testing%20Farm/0.1/index.html) with the [tft.yml](https://github.com/linux-system-roles/trustee_attestation_server/blob/main/.github/workflows/tft.yml) GitHub workflow.
```
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

nitpick (typo): Consider capitalizing "Farm" in "Testing Farm" to match the official service name.

The official name is "Testing Farm" with both words capitalized. Please update the link text accordingly.

Suggested change

	Linux System Roles CI runs [tmt](https://tmt.readthedocs.io/en/stable/index.html) test plans in [Testing farm](https://docs.testing-farm.io/Testing%20Farm/0.1/index.html) with the [tft.yml](https://github.com/linux-system-roles/trustee_attestation_server/blob/main/.github/workflows/tft.yml) GitHub workflow.
	Linux System Roles CI runs [tmt](https://tmt.readthedocs.io/en/stable/index.html) test plans in [Testing Farm](https://docs.testing-farm.io/Testing%20Farm/0.1/index.html) with the [tft.yml](https://github.com/linux-system-roles/trustee_attestation_server/blob/main/.github/workflows/tft.yml) GitHub workflow.