Skip to content

Check psng_hook return value for error conditions#44

Open
kiall wants to merge 1 commit intomasterfrom
check-hook-return
Open

Check psng_hook return value for error conditions#44
kiall wants to merge 1 commit intomasterfrom
check-hook-return

Conversation

@kiall
Copy link
Copy Markdown
Contributor

@kiall kiall commented Dec 27, 2020

Any return value less than 0 will be treated as a failure, and will abort
the remainder of the macro execution.

Any return value less than 0 will be treated as a failure, and will abort
the remainder of the macro execution.
@alkabal
Copy link
Copy Markdown
Contributor

alkabal commented Dec 27, 2020

Imo this can be done directly in hook
I see hook like a safe check and this one need to manage all possible situation and choose to abort herself if needed

using (abort,blabla) in hook seem to work fine for stopping all the process, but I can verify that this evening

@alkabal
Copy link
Copy Markdown
Contributor

alkabal commented Dec 27, 2020

The things I think that need enhanced is using stop button from GUI regardless to pause condition or in movement need to cancel the whole operation and not only a part of the next operation

@alkabal
Copy link
Copy Markdown
Contributor

alkabal commented Dec 27, 2020

Maybe add this inside hook as example seem to be enough :

o10 if [#<hooked_macro> GT 9]
(ABORT, HOOK UNRECOGNIZED : #<hooked_macro>)
o10 endif

@alkabal
Copy link
Copy Markdown
Contributor

alkabal commented Dec 27, 2020

psng_hook.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants