-
Notifications
You must be signed in to change notification settings - Fork 110
feat: Add SPDX header check workflow for pull requests #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SPDX header check workflow for pull requests #776
Conversation
|
Hi @Copilot. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: zccrs <13449038+zccrs@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Copilot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
CLA Assistant Lite bot: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不太能合。问题如下:
- 目前的 linuxdeepin 下的 CI 工作方式是每个项目下有个 call-xxx.yaml 的形式调 linuxdeepin/.github 下的工作流,这个提交并不会变成组织级别的公共工作流。
- 此类 CI 应当仅检查特定著作权人(deepin/uniontech之类)所声明的著作权的时间,避免确有需要 vendor 代码时的误伤
- 针对 vendor 代码的情况,REUSE 规范允许通过 REUSE.toml/dep5/.license 文件来声明许可,当前的 action 看上去不支持此类情况
可能的可行建议:
- 整合到现有的 license check CI 里(比如多写一个 job,或者追加到现有的 job 里)
- 针对第二条的描述,差异化检查/跳过检查
- 可以考虑利用 reuse spdx 的输出来核对每个文件所对应的著作权信息列表,然后结合 2 以及 PR 的变动情况做相应的检查
Adds automated SPDX copyright header validation for all PRs targeting main branch.
Changes
.github/workflows/spdx-check.ymlzccrs/github-actions-spdx-checker@mainactionvendor/**,node_modules/**,3rdparty/**, and*.jsonfilesBehavior
New and modified files will be checked for:
Non-compliant files will fail the check with detailed feedback.
Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.