[dde-calendar] Updates for project Deepin Desktop Environment#322
Closed
transifex-integration[bot] wants to merge 8 commits intomasterfrom
Closed
[dde-calendar] Updates for project Deepin Desktop Environment#322transifex-integration[bot] wants to merge 8 commits intomasterfrom
transifex-integration[bot] wants to merge 8 commits intomasterfrom
Conversation
100% translated source file: 'dde-calendar_en_US.ts' on 'es'.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: transifex-integration[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @transifex-integration[bot]. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's GuideThis PR updates the Spanish Qt translation file for dde-calendar, adjusting capitalization, terminology, and some strings’ wording while also normalizing the XML/TS header and pruning redundant source-location references generated by lupdate. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
99% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'es'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The translation changes mix both “Borrar” and “Eliminar” for destructive actions; consider standardizing on one verb throughout the calendar UI for consistency (e.g., all delete operations using the same term).
- The pair of strings
Time:andTimeare now translated asCalendario:andHora; it would be clearer to use a consistent concept (likelyHora:/Hora) so the label and value match semantically. - For the
ICS File:string, the English source includes a trailing colon but the Spanish translationArchivo ICSomits it; consider adding the colon (Archivo ICS:) to match the UI formatting and the source string structure.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The translation changes mix both “Borrar” and “Eliminar” for destructive actions; consider standardizing on one verb throughout the calendar UI for consistency (e.g., all delete operations using the same term).
- The pair of strings `Time:` and `Time` are now translated as `Calendario:` and `Hora`; it would be clearer to use a consistent concept (likely `Hora:` / `Hora`) so the label and value match semantically.
- For the `ICS File:` string, the English source includes a trailing colon but the Spanish translation `Archivo ICS` omits it; consider adding the colon (`Archivo ICS:`) to match the UI formatting and the source string structure.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
100% translated source file: 'dde-calendar-service_en_US.ts' on 'es'.
100% translated source file: 'dde-calendar_en_US.ts' on 'es'.
100% translated source file: 'dde-calendar-service_en_US.ts' on 'uk'.
100% translated source file: 'dde-calendar_en_US.ts' on 'uk'.
100% translated source file: 'dde-calendar_en_US.ts' on 'fi'.
99% of minimum 50% translated source file: 'dde-calendar-service_en_US.ts' on 'fi'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following localization files have been updated:
Details
Files