Skip to content

style(hotspot): optimize hotspot dialog UI appearance#543

Merged
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
add-uos:fix/BUG-316567
Apr 9, 2026
Merged

style(hotspot): optimize hotspot dialog UI appearance#543
deepin-bot[bot] merged 1 commit intolinuxdeepin:masterfrom
add-uos:fix/BUG-316567

Conversation

@add-uos
Copy link
Copy Markdown
Contributor

@add-uos add-uos commented Apr 8, 2026

Add transparent background to hotspot dialog and change save button to recommended button style for better visual consistency.

添加透明背景并将保存按钮改为推荐按钮样式。

Log: 优化热点对话框UI
PMS: BUG-316567
Influence: 热点对话框界面更加美观统一,提升用户体验。

Summary by Sourcery

Refine the hotspot configuration dialog appearance for a more consistent and polished UI.

Enhancements:

  • Make the hotspot dialog background transparent for better visual integration with the surrounding UI.
  • Update the hotspot dialog save action to use the recommended button style for visual consistency.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 8, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the hotspot dialog’s visual styling by making the dialog background transparent and updating the Save control to use the standardized recommended button component for better UI consistency.

File-Level Changes

Change Details Files
Make hotspot dialog background transparent to blend better with surrounding UI.
  • Set the dialog color property to transparent
  • Keep existing modal width and icon settings unchanged while altering only background appearance
dcc-network/qml/PageHotspot.qml
Update the Save action control to use the standardized recommended button style.
  • Replace the generic button component with the RecommandButton variant for the Save action
  • Preserve layout, label text, and behavior while changing only the visual style component
dcc-network/qml/PageHotspot.qml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Using a fully transparent dialog background may hurt readability when the underlying content is visually busy; consider using a themed background with partial opacity (or following whatever pattern other dialogs in this app use) to maintain contrast while still lightening the UI.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Using a fully transparent dialog background may hurt readability when the underlying content is visually busy; consider using a themed background with partial opacity (or following whatever pattern other dialogs in this app use) to maintain contrast while still lightening the UI.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.


modality: Qt.ApplicationModal
width: 380
color: "transparent"
Copy link
Copy Markdown
Contributor

@18202781743 18202781743 Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该在dtk里修一下吧,另外防止去掉了窗口模糊后背景不对的问题,参照这种修改下,https://github.com/linuxdeepin/dde-shell/blob/f4f526260a764bcc5e811b60d8273edc45ca35f6/panels/dock/package/main.qml#L400

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一样式在:linuxdeepin/dtkdeclarative#600

change save button to recommended button style for
better visual consistency.

添加透明背景并将保存按钮改为推荐按钮样式。

Log: 优化热点对话框UI
PMS: BUG-316567
Influence: 热点对话框界面更加美观统一,提升用户体验。
@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, add-uos

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@add-uos
Copy link
Copy Markdown
Contributor Author

add-uos commented Apr 9, 2026

/forcemerge

@deepin-bot
Copy link
Copy Markdown
Contributor

deepin-bot bot commented Apr 9, 2026

This pr force merged! (status: unstable)

@deepin-bot deepin-bot bot merged commit ff7ad66 into linuxdeepin:master Apr 9, 2026
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants