Skip to content

fix: Gradia-like capture causes treeland crashed #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LFRon wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

fix: Gradia-like capture causes treeland crashed #827

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/modules/capture/capture.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright (C) 2024 UnionTech Software Technology Co., Ltd.
// Copyright (C) 2024-2026 UnionTech Software Technology Co., Ltd.
// SPDX-License-Identifier: Apache-2.0 OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only

#include "capture.h"
Expand Down Expand Up @@ -580,7 +580,10 @@ void CaptureSourceSelector::doneSelection()
this,
&CaptureSourceSelector::createImage);
m_internalContentItem->setVisible(false);
m_canvas->surfaceItem()->setSubsurfacesVisible(false);
// m_canvas may be null when no mask surface exists (e.g. capture via
// xdg-desktop-portal without a mask). Guard against null dereference.
if (m_canvas && m_canvas->surfaceItem())
m_canvas->surfaceItem()->setSubsurfacesVisible(false);
}

void CaptureSourceSelector::cancelSelection()
Expand Down
Loading