fix: ignore results that have no activity data (CM-1112)#4033
fix: ignore results that have no activity data (CM-1112)#4033
Conversation
Signed-off-by: Uroš Marolt <uros@marolt.me>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 72ac5c3. Configure here.
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent malformed activity results (where data.data is missing / not an activity object) from crashing a batch by treating them as “processed” and skipping further work.
Changes:
- Changes the
!activityguard inprepareMemberDatato log a warning and mark the result assuccess: trueinstead of failing with anUnrepeatableError.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Uroš Marolt <uros@marolt.me>
Signed-off-by: Uroš Marolt <uros@marolt.me>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Uroš Marolt <uros@marolt.me>

Note
Medium Risk
Changes batch-processing behavior to treat missing
activitypayloads as successful/processed rather than failed, which can silently drop bad inputs but prevents whole-batch failures/crashes.Overview
Prevents
processActivitiesbatches from failing when a payload has noactivitydata by skipping those items and marking theirresultIdas successfully processed, with a warning log.Aligns
prepareMemberDatahandling so missingactivityno longer produces anUnrepeatableError; it now warns and returns success for that item, avoiding batch-wide errors fromTypeErrorwhen accessingactivity.username.Reviewed by Cursor Bugbot for commit e7f3f57. Bugbot is set up for automated code reviews on this repo. Configure here.