Update default.conf.sample to deny dotfile access#48
Conversation
Signed-off-by: Eric Nemchik <eric@nemchik.com>
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
|
I am a bot, here are the test results for this PR:
|
Signed-off-by: Eric Nemchik <eric@nemchik.com>
There was a problem hiding this comment.
Pull request overview
Updates the bundled nginx site config sample for the phpMyAdmin container to harden access rules around hidden “dotfiles”, and records the change in the README changelog variables.
Changes:
- Add nginx
locationrules to allow/.well-knownwhile denying access to all other dotfiles. - Add QUIC
listendirectives on 443 (HTTP/3-related) in the sample config. - Add a new changelog entry in
readme-vars.ymldescribing the dotfile access change.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
root/defaults/nginx/site-confs/default.conf.sample |
Adds dotfile deny + /.well-known allow rules; also introduces QUIC listeners and formatting tweaks. |
readme-vars.yml |
Adds a changelog entry instructing existing users to update nginx site config for dotfile denial. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| listen 443 ssl default_server; | ||
| listen [::]:443 ssl default_server; | ||
| listen 443 quic reuseport default_server; | ||
| listen [::]:443 quic reuseport default_server; |
| # Allow access to the ".well-known" directory | ||
| location ^~ /.well-known { | ||
| allow all; | ||
| } | ||
|
|
| "phpmyadmin:latest" <- Base Images | ||
| # changelog | ||
| changelogs: | ||
| - {date: "08.02.26:", desc: "Existing users should update: site-confs/default.conf - Deny access to all dotfiles."} |
|
I am a bot, here are the test results for this PR:
|
No description provided.