Skip to content

fix: ShellCheck SC2086#191

Closed
MattKobayashi wants to merge 1 commit intolinuxserver:masterfrom
MattKobayashi:shellcheck-fix
Closed

fix: ShellCheck SC2086#191
MattKobayashi wants to merge 1 commit intolinuxserver:masterfrom
MattKobayashi:shellcheck-fix

Conversation

@MattKobayashi
Copy link
Copy Markdown
Contributor

@MattKobayashi MattKobayashi commented Mar 21, 2025

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Fixes a reported instance of SC2086.

Benefits of this PR and context:

ShellCheck results from another PR showed an instance of SC2086. This PR fixes the issue.

How Has This Been Tested?

Container builds and runs successfully.

Source / References:

https://www.shellcheck.net/wiki/SC2086
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-b8b8881c-dev-21656cc84de83c64a7eadd1274301dccf54d6074-pr-189/shellcheck-result.xml

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-b8b8881c-dev-20f18b5675f08cfe3cbcf6c1121ddffce158b9e6-pr-191/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-b8b8881c-dev-20f18b5675f08cfe3cbcf6c1121ddffce158b9e6-pr-191/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-b8b8881c-dev-20f18b5675f08cfe3cbcf6c1121ddffce158b9e6-pr-191
arm64v8-2.8.2-r3-pkg-b8b8881c-dev-20f18b5675f08cfe3cbcf6c1121ddffce158b9e6-pr-191

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-ed6dce9e-dev-047c0c5cc93beeacf2b3964e519a69d74941da9f-pr-191/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-ed6dce9e-dev-047c0c5cc93beeacf2b3964e519a69d74941da9f-pr-191/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-ed6dce9e-dev-047c0c5cc93beeacf2b3964e519a69d74941da9f-pr-191
arm64v8-2.8.2-r3-pkg-ed6dce9e-dev-047c0c5cc93beeacf2b3964e519a69d74941da9f-pr-191

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-8b437131-dev-317ad1d78ee2851b827d94b62ca8b1ecbf0a7158-pr-191/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-8b437131-dev-317ad1d78ee2851b827d94b62ca8b1ecbf0a7158-pr-191/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-8b437131-dev-317ad1d78ee2851b827d94b62ca8b1ecbf0a7158-pr-191
arm64v8-2.8.2-r3-pkg-8b437131-dev-317ad1d78ee2851b827d94b62ca8b1ecbf0a7158-pr-191

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-53d767fd-dev-705510abf28a91f21b2be0c6a0863653aa2df621-pr-191/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-53d767fd-dev-705510abf28a91f21b2be0c6a0863653aa2df621-pr-191/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-53d767fd-dev-705510abf28a91f21b2be0c6a0863653aa2df621-pr-191
arm64v8-2.8.2-r3-pkg-53d767fd-dev-705510abf28a91f21b2be0c6a0863653aa2df621-pr-191

@thespad thespad mentioned this pull request Jun 3, 2025
1 task
@thespad
Copy link
Copy Markdown
Member

thespad commented Jun 3, 2025

Superseded by #196

@thespad thespad closed this Jun 3, 2025
@LinuxServer-CI LinuxServer-CI moved this from PRs to Done in Issue & PR Tracker Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants