Skip to content

Enable Curl as default probe type#192

Closed
tbussmann wants to merge 2 commits intolinuxserver:masterfrom
tbussmann:patch-1
Closed

Enable Curl as default probe type#192
tbussmann wants to merge 2 commits intolinuxserver:masterfrom
tbussmann:patch-1

Conversation

@tbussmann
Copy link
Copy Markdown

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

Despite the curl binary is available, it's not possible to add target using probe = Curl in Targets because the probe is not declared in Probes.

Benefits of this PR and context:

This makes it easier to use probes of type Curl. In the readme there is no mention of the need to edit Probes file, only Targets.

How Has This Been Tested?

This has been tested with a demo target. The minimal default values are taken from documentation.

Discussion

  • Shall there be a sample in the Targets file?
  • Is the default config useful as is?
  • Would it be better to use AnotherCurl instead of Curl?

Source / References:

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5be6fcde-dev-00b7124abfdc4d06d4ea932d335bdf70802294ef-pr-192/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-5be6fcde-dev-00b7124abfdc4d06d4ea932d335bdf70802294ef-pr-192/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-5be6fcde-dev-00b7124abfdc4d06d4ea932d335bdf70802294ef-pr-192
arm64v8-2.8.2-r3-pkg-5be6fcde-dev-00b7124abfdc4d06d4ea932d335bdf70802294ef-pr-192

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-ed6dce9e-dev-9291b82849099cb965adb12a023714b325124ba3-pr-192/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-ed6dce9e-dev-9291b82849099cb965adb12a023714b325124ba3-pr-192/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-ed6dce9e-dev-9291b82849099cb965adb12a023714b325124ba3-pr-192
arm64v8-2.8.2-r3-pkg-ed6dce9e-dev-9291b82849099cb965adb12a023714b325124ba3-pr-192

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-8b437131-dev-6290af4bfd2d8f9cd75bf0f667d97b5c938be492-pr-192/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-8b437131-dev-6290af4bfd2d8f9cd75bf0f667d97b5c938be492-pr-192/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-8b437131-dev-6290af4bfd2d8f9cd75bf0f667d97b5c938be492-pr-192
arm64v8-2.8.2-r3-pkg-8b437131-dev-6290af4bfd2d8f9cd75bf0f667d97b5c938be492-pr-192

@LinuxServer-CI
Copy link
Copy Markdown
Collaborator

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-53d767fd-dev-53d92b16ba2ea4073f5036130fb34a2a5b8493fc-pr-192/index.html
https://ci-tests.linuxserver.io/lspipepr/smokeping/2.8.2-r3-pkg-53d767fd-dev-53d92b16ba2ea4073f5036130fb34a2a5b8493fc-pr-192/shellcheck-result.xml

Tag Passed
amd64-2.8.2-r3-pkg-53d767fd-dev-53d92b16ba2ea4073f5036130fb34a2a5b8493fc-pr-192
arm64v8-2.8.2-r3-pkg-53d767fd-dev-53d92b16ba2ea4073f5036130fb34a2a5b8493fc-pr-192

@thespad thespad mentioned this pull request Jun 3, 2025
1 task
@thespad
Copy link
Copy Markdown
Member

thespad commented Jun 3, 2025

Superseded by #196

@thespad thespad closed this Jun 3, 2025
@LinuxServer-CI LinuxServer-CI moved this from PRs to Done in Issue & PR Tracker Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants