performance optimze for stdf4j#2
Open
lantianjialiang wants to merge 8 commits intoliquidkarma:masterfrom
Open
Conversation
performance optimize: 1. change the ByteArray to singleton 2. new Float/Double to Float/Double.valueOf 3. change the "new String(cbuf, 0, length).intern()" to new String(data, offset, length, ASCII) 4. change the Arrays.copyOfRange to System.arraycopy one 1.2G stdf file need 24s with "record.getData()" called, after optimized, the time is 6.8s~7.2s(test env, RHEL7.4, Java 1.8)
add the exception to RecordVisitor; change the record name to upper case in xml file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the key point is change the string.intern to String(data, offset, length, ASCII)