Draft
Conversation
… to check them carefully)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Metric Addition: Track Accuracy Over Time
Closes #30
From https://www.nature.com/articles/s41587-022-01427-7, implemented in https://github.com/funkelab/linajea/blob/754ca57a67758e670bb4d2366ddadb7fa0045f1d/linajea/evaluation/evaluator.py#L409
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
tests/bench.py.Discussion Questions
Question 1: How to count window sizes with skip edges
When a ground truth skip edge spans multiple frames (e.g., t=0 → t=3), how should we count it?
Option A: Count only at actual frame span (current implementation)
Option B: Interpolate intermediate windows CHOSE THIS OPTION WITH DRAGA*
Option C: Count as single edge (original implementation)
Question 2: Should we add a flag to include ground truth segments that end early in larger window sizes? To make it equivalent to complete tracks from the CTC-BIO?
Yes, it should be complete and correct for all later window sizes (not even a flag, just do it). Note in docs that many short GT tracks might upweight the total correct fractions. Normalized by length is "track effectiveness"
"Question" 3: Design difference at start of time window
When computing track/lineage accuracy over time, linajea skips checking error flags on the start node of each segment, while traccuracy checks all nodes including the start node.
Specifically, in linajea's
get_perfect_segments(evaluator.py:433):