Open
Conversation
Add agentName and sandboxId to APP_CONFIG_DEFAULTS so they are no longer silently dropped when received from the sandbox config endpoint. Fix the type guard in getAppConfig() to allow undefined defaults to be overwritten by typed remote values. Set Content-Security-Policy: frame-ancestors * on /embed and /test/popup routes so these pages can be loaded in iframes on third-party sites. Required for the Cloud embed widget feature.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Topherhindman
changed the title
Vercel blocks deployments on vulnerable Next.js versions.
Topherhindman
force-pushed
the
topherhindman/grw-173-embed-config-fix
branch
from
266cae1 to
5109aec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
agentNameandsandboxIdtoAPP_CONFIG_DEFAULTSso they are no longer silently dropped when received from the sandbox config endpoint. Fix the type guard ingetAppConfig()to allow undefined defaults to be overwritten by typed remote values.Set
Content-Security-Policy: frame-ancestors *on/embedroute so this page can be loaded in iframes on third-party sites.